REF: extract BlueSpacing from BlueComponents.js #7910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limpbrains
requested changes
May 30, 2025
limpbrains
approved these changes
May 30, 2025
…anilobatson/BlueWallet into ref/7909-move-blue-spacing-to-own-file
marcosrdz
approved these changes
May 31, 2025
Contributor
Author
|
@marcosrdz @limpbrains @Overtorment Thanks for the approval! As this would be my first merge here with you all, what would be next steps here as I am not authorized to merge? |
Contributor
Author
|
@limpbrains @marcosrdz can I get an assist on getting this merged? Have the two review approvals. |
Member
|
oops, needs conflicts resolved, otherwise lgtm |
Contributor
Author
@Overtorment just resolved the conflicts. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7909
Summary
This PR refactors the
BlueSpacingcomponent by extracting it fromBlueComponents.jsinto its own dedicated file (BlueSpacing.tsx).Changes
BlueSpacingand alike components fromBlueComponents.jsBlueSpacing.tsxfileBlueComponents.js where it is then exported for relevant filesType of Change
Checklist