ref: convert aztecoRedeem to TS #7871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limpbrains
force-pushed
the
azteco-ts
branch
2 times, most recently
from
ff19198 to
df86b1f
Compare
APK Successfully Uploaded to BrowserStackYou can test it on the following devices:
|
marcosrdz
approved these changes
Aug 9, 2025
Member
marcosrdz
left a comment
marcosrdz
left a comment
There was a problem hiding this comment.
What do you think of using the Privacy util hook? To avoid screen recording the code (third party apps running on background could maliciously see that info)
Overtorment
approved these changes
Aug 9, 2025
| navigation.navigate(...completionValue); | ||
| }); | ||
| } catch (e: any) { | ||
| Alert.alert(loc.send.details_scan_error, e.message); |
Member
There was a problem hiding this comment.
i have doubts it will ever throw, because the method is not async.
i think if smth is not right it just won't shoot the callback
Collaborator
Author
There was a problem hiding this comment.
You are right, my case was before async logic starts
Collaborator
|
Unbelievable. You, [subject name here], must be the pride of [subject hometown here]! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen_Recording_20250808_195128_BlueWallet.mp4