Skip to content

Conversation

@marcosrdz
Copy link
Member

No description provided.

@marcosrdz marcosrdz requested a review from Overtorment January 30, 2025 01:52
@marcosrdz marcosrdz self-assigned this Jan 30, 2025
@GladosBlueWallet
Copy link
Collaborator

Copy link
Member

@Overtorment Overtorment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

const string2hash = [...this._cosignersFingerprints].sort().join(',');
const id = createHash('sha256').update(string2hash).digest().toString('hex');
return id;
const string2hash = [...this._cosigners].sort().join(',') + ';' + [...this._cosignersFingerprints].sort().join(',');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically you brought back old version..?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

@marcosrdz marcosrdz merged commit b21cf6e into master Jan 30, 2025
12 of 13 checks passed
@marcosrdz marcosrdz deleted the multisi branch January 30, 2025 19:37
davidreband pushed a commit to davidreband/DoiWallet that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants