REF: replace Buffer with Uint8Array where possible

ojokne · ojokne · commit 9a8e12268fb9 · 2025-10-06T06:53:24.000+03:00
- remove double conversion Uint8Array(hexToUint8Array(..))
- replace TextDecoder with uint8ArrayToString
- remove redundant if block
- revert unnecessary conversion in class/wallets/multisig-hd-wallet.ts
- remove Buffer from ecc.isPoint
diff --git a/class/contact-list.ts b/class/contact-list.ts
@@ -32,7 +32,7 @@ export class ContactList {
       const decoded = bitcoin.address.fromBech32(address);
       if (decoded.version === 0) return true;
       if (decoded.version === 1 && decoded.data.length !== 32) return false;
-      if (decoded.version === 1 && !ecc.isPoint(Buffer.from(concatUint8Arrays([new Uint8Array([2]), decoded.data])))) return false;
+      if (decoded.version === 1 && !ecc.isPoint(concatUint8Arrays([new Uint8Array([2]), decoded.data]))) return false;
       if (decoded.version > 1) return false;
       // ^^^ some day, when versions above 1 will be actually utilized, we would need to unhardcode this
       return true;
diff --git a/class/wallets/abstract-hd-electrum-wallet.ts b/class/wallets/abstract-hd-electrum-wallet.ts
@@ -1685,7 +1685,7 @@ export class AbstractHDElectrumWallet extends AbstractHDWallet {
       bobBip47,
       keyPair.privateKey as Buffer,
       // txid is reversed, as well as output number
-      uint8ArrayToHex(new Uint8Array(hexToUint8Array(inputsTemp[0].txid)).reverse()) + uint8ArrayToHex(outputNumber),
+      uint8ArrayToHex(hexToUint8Array(inputsTemp[0].txid).reverse()) + outputNumber.toString('hex'),
     );
 
     // targets:
diff --git a/class/wallets/multisig-hd-wallet.ts b/class/wallets/multisig-hd-wallet.ts
@@ -13,7 +13,7 @@ import ecc from '../../blue_modules/noble_ecc';
 import { decodeUR } from '../../blue_modules/ur';
 import { AbstractHDElectrumWallet } from './abstract-hd-electrum-wallet';
 import { CreateTransactionResult, CreateTransactionTarget, CreateTransactionUtxo } from './types';
-import { uint8ArrayToHex, hexToUint8Array, concatUint8Arrays } from '../../blue_modules/uint8array-extras';
+import { uint8ArrayToHex, hexToUint8Array, concatUint8Arrays, uint8ArrayToString } from '../../blue_modules/uint8array-extras';
 
 const ECPair = ECPairFactory(ecc);
 const bip32 = BIP32Factory(ecc);
@@ -517,7 +517,7 @@ export class MultisigHDWallet extends AbstractHDElectrumWallet {
     if (secret.toUpperCase().startsWith('UR:BYTES')) {
       const decoded = decodeUR([secret]) as string;
       const b = hexToUint8Array(decoded);
-      secret = new TextDecoder().decode(b);
+      secret = uint8ArrayToString(b);
     }
 
     // is it Coldcard json file?
@@ -629,10 +629,7 @@ export class MultisigHDWallet extends AbstractHDElectrumWallet {
         const re = /\[([^\]]+)\](.*)/;
         const m = s3[c].match(re);
         if (m && m.length === 3) {
-          let hexFingerprint = m[1].split('/')[0];
-          if (hexFingerprint.length === 8) {
-            hexFingerprint = uint8ArrayToHex(hexToUint8Array(hexFingerprint));
-          }
+          const hexFingerprint = m[1].split('/')[0];
 
           let path = 'm/' + m[1].split('/').slice(1).join('/').replace(/[h]/g, "'");
           if (path === 'm/') {
@@ -1071,7 +1068,7 @@ export class MultisigHDWallet extends AbstractHDElectrumWallet {
   }
 
   static isPathValid(path: string): boolean {
-    const root = bip32.fromSeed(Buffer.from(new Uint8Array(32)));
+    const root = bip32.fromSeed(Buffer.alloc(32));
     try {
       root.derivePath(path);
       return true;
