Skip to content

Unlocalised strings for non-English languages show up as localisation keys when the browser sends a non-English Accept-Language header, affecting both auto-detected and set-via-preference-pane webapp languages #631

@akemin-dayo

Description

@akemin-dayo

Steps to reproduce

  • Use a browser that sends a non-English Accept-Language header. For instance, ja-JP or ja in my case. ※ You can also set this using Chromium DevTools.
  • Open a version of the webapp that contains commit e59d035. Both master (7392447) and stable 5.5 are affected, including the demo instance as of this writing. (Also affects my backport which includes the same commit, but that's not really relevant here.)
  • Open the side menu and notice that strings that unlocalised strings show up not in English, but in their key form.
  • Open the preference pane and change the language to English.
  • Now change it back to whatever language you had before. (※ Japanese in my case)
  • Previously untranslated keys will now show up correctly as English strings.
  • Refresh the webapp.
  • Observe that untranslated strings are in their key form again.

Expected result

  • Untranslated strings should appear as English strings, not as localisation keys.

Actual result

  • Localisation keys appear instead of English strings for untranslated strings.

Context

BlueMap Version: 7392447
※ Also affects the demo instance: https://bluecolored.de/bluemap/

Screenshots (JP)

image image image

Screenshots (KR)

image image image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions