Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Deploy gcc 9.3.0#789

Merged
iomaganaris merged 17 commits intodevelopfrom
update/gcc
May 11, 2020
Merged

Deploy gcc 9.3.0#789
iomaganaris merged 17 commits intodevelopfrom
update/gcc

Conversation

@iomaganaris
Copy link
Copy Markdown

Update deployed gcc version to 9.3.0 to fix issues with gcc 9.2.0

version = version[0:-1].strip()
version_str = str(version)
if version_str[-1] in string.ascii_letters:
version_str = version_str[0:-1].strip()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version_str = version_str[0:-1].strip()
version_str = version_str[:-1].strip()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that you really need the strip, too

Copy link
Copy Markdown
Author

@iomaganaris iomaganaris Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I don't like this workaround a lot though and I now saw that when jenkins builds gcc it uses the packages from /gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/compilers/2020-02-01/linux-rhel7-x86_64/gcc-4.8.5/, so redeploying a different version of mpc might not be needed to deploy gcc 9.3.0. The problematic mpc installation is the one included in packages.yaml and there might be an issue just when building gcc locally

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's only GCC 9 that relies on mpc, then yes, it does not seem to make much sense to redeploy the one that ends up in packages.yaml, since that comes from tools/external-libraries.

@iomaganaris iomaganaris marked this pull request as ready for review April 30, 2020 18:18
@iomaganaris iomaganaris requested a review from pramodk April 30, 2020 18:18
@iomaganaris iomaganaris merged commit 81b3dad into develop May 11, 2020
@iomaganaris iomaganaris deleted the update/gcc branch May 11, 2020 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants