This repository was archived by the owner on Feb 26, 2025. It is now read-only.
deployment: consolidate environments and module config#1239
Merged
Conversation
matz-e
force-pushed
the
move-configs-into-environments
branch
from
dfbbf0c to
f6fd463
Compare
Member
Author
|
Retest this please |
matz-e
force-pushed
the
move-configs-into-environments
branch
from
f6fd463 to
9ce6147
Compare
Member
Author
|
Retest this please Another purge of the installation directory |
1 similar comment
Member
Author
|
Retest this please Another purge of the installation directory |
Moves the part of the module configuration that is specific to the environment into the environment definition: * simplifies our setup * now there is one global module config (blacklisting everything) * whitelists are in the same file as specs to build
matz-e
force-pushed
the
move-configs-into-environments
branch
from
918071d to
ddde8dd
Compare
Member
Author
|
@pramodk would be nice to get this in… would simplify refactoring quite a bit! |
pramodk
approved these changes
Sep 7, 2021
pramodk
left a comment
pramodk
left a comment
There was a problem hiding this comment.
Nothing specific that I can notice as problematic, LGTM!
| target: x86_64 | ||
| environment: {} | ||
| extra_rpaths: [] | ||
| modules: [] |
There was a problem hiding this comment.
Is this new one / needed ? (spack compiler find should generate this, right?)
Member
Author
There was a problem hiding this comment.
Yes… but I also wanted to have this as a central configuration to build on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the part of the module configuration that is specific to the
environment into the environment definition:
Otherwise, there are very few changes:
compilers.yamlwith RH compilers is in~/.spack/linuxto exclude those from the regular compilers