Respect NUMEXPR_MAX_THREADS when setting numexpr thread count#567
Merged
FrancescAlted merged 1 commit intoBlosc:mainfrom Jan 29, 2026
Merged
Respect NUMEXPR_MAX_THREADS when setting numexpr thread count#567FrancescAlted merged 1 commit intoBlosc:mainfrom
FrancescAlted merged 1 commit intoBlosc:mainfrom
Conversation
Avoid calling numexpr.set_num_threads() with a value exceeding NUMEXPR_MAX_THREADS to prevent numexpr from printing a warning to stderr during blosc2 import. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Member
|
Thanks @skmendez . I am wondering if this patch would be better suited in numexpr package itself. Thoughts? |
Author
|
I think it makes sense to warn if you attempt to set the number of threads to a value greater than |
Member
|
Ok, after discussions with @lshaw8317 we have decided to let pass this one here, and keep the original error in numexpr, which has a much larger userbase, so changes like this may bring surprises to more people. |
Member
|
Thanks again @skmendez ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid calling numexpr.set_num_threads() with a value exceeding NUMEXPR_MAX_THREADS to prevent numexpr from printing a warning to stderr during blosc2 import. Without this, I get the following error log from numexpr: