Improve integration of web front-end #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… directories.
Rewrite server.py: @app.get('/') and @app.get('/faq') to serve the front-end.
bwakedavis
changed the title
bwakedavis
changed the title
nochiel
requested changes
Aug 25, 2022
Contributor
nochiel
left a comment
nochiel
left a comment
There was a problem hiding this comment.
Thanks for your work @bwakedavis.
.gitignoreshould be removed from the repository. Each programmers can configure it for themselves since it's not material to Spotbit.- What are the following for? Can we remove them for now given that they don't have any functionality?
static/assets/js/requests.jsstatic/assets/requests_in_ts/requests.ts
- I think we should remove all Javascript libraries that are in the repositories and instead use the ones supplied by official CDNs. That way we have fewer dependencies to worry about maintaining. Always prefer to link to libraries on CDNs.
Contributor
Author
|
Thanks @nochiel for the review, I have updated and pushed the suggested changes |
5 tasks
Contributor
|
Merging thanks to review from @nochiel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
templatesandstaticdirectoriesserver.py:app('/')to serve the front-endaboutpage