A proposal for implementing #124#162
Conversation
…e keys and returning all keys from local storage
|
Let me know @chrissainty if anything else is needed! 👍 |
|
Anything more I can do, @chrissainty ? 😊 |
|
My apologies for the delay on this @koskila.I've been swamped with work stuff. I'm hoping to look at tomorrow |
koskila
left a comment
koskila
left a comment
There was a problem hiding this comment.
I ran the tests and was happy not seeing any failed ones - but ignored the fact that my test crashed the whole test run. Yikes.
Fixed that, now I can only see green. 😅
chrissainty
left a comment
chrissainty
left a comment
There was a problem hiding this comment.
Thank you for your work on this so far @koskila. I do have a few changes, if that's ok. I've left a few suggested changes. Also, I can't see a synchronous version of the new GetKeys method, or an async version of the new RemoveItems method. Could these be added as well please?
The synchronous and asynchronous APIs should be the same.
Co-authored-by: Chris Sainty <[email protected]>
Co-authored-by: Chris Sainty <[email protected]>
chrissainty
left a comment
chrissainty
left a comment
There was a problem hiding this comment.
Hey @koskila, I might be missing something as I'm reviewing on my phone but is the ISyncLocalStorageSerive exposing all the new methods? Looks the the new Keys method is missing still?
chrissainty
left a comment
chrissainty
left a comment
There was a problem hiding this comment.
Thanks for this, @koskila! great work
2 participants
This seemed like a simple enough ask - it's essentially just a wrapper for Object.keys(localStorage) and for calling localStorage.clear(key) multiple times, but hey, let's call it a quality-of-life upgrade? 😅