Upgrade to .net6#157
Conversation
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net5.0'"> | ||
| <PackageReference Include="Microsoft.AspNetCore.Components" Version="$(DotNet5Version)" /> |
There was a problem hiding this comment.
Microsoft.AspNetCore.Components.Web has a dependency to this package so no need to extra reference it.
IbrahimHabibeh
left a comment
IbrahimHabibeh
left a comment
There was a problem hiding this comment.
Change all references to version 6.0.100-preview.6.21355.2 to be the latest 6.0.0-preview.7.21378.6
Done. |
|
@linkdotnet - WOuld it be possible to update this to the RTM release and then we can look at getting it merged? |
|
Hey @chrissainty thanks for updating the branch. |
| - uses: actions/setup-dotnet@v1 | ||
| with: | ||
| dotnet-version: '6.0.100' | ||
|
|
There was a problem hiding this comment.
Hmm good catch.For the Preview version it was needed for sure because the autobuild of codeql does take the latest stable version. I'll check quickly
There was a problem hiding this comment.
Yes it is needed @chrissainty
I removed it from one of my projects just to test see here
Also check the offical tracker: here
Currently they are only supporting .NET 5.
Only workaround is the global.json
Money quote
Running dotnet --info
.NET SDK (reflecting any global.json):
Version: 5.0.403
Commit: bf9d168ac2
Runtime Environment:
OS Name: ubuntu
OS Version: 20.04
OS Platform: Linux
RID: ubuntu.20.04-x64
Base Path: /usr/share/dotnet/sdk/5.0.403/
Co-authored-by: Chris Sainty <[email protected]>
|
Hey @chrissainty is there anything open for you? |
| <Target Name="RemoveLoggingAnalyzer" BeforeTargets="CoreCompile"> | ||
| <ItemGroup> | ||
| <Analyzer Remove="@(Analyzer)" Condition="%(FileName) == 'Microsoft.Extensions.Logging.Generators'" /> | ||
| </ItemGroup> | ||
| </Target> |
There was a problem hiding this comment.
Can we add a TargetFramework check for this?
There was a problem hiding this comment.
Very valid point. Added the condition
| <Target Name="RemoveLoggingAnalyzer" BeforeTargets="CoreCompile"> | ||
| <ItemGroup> | ||
| <Analyzer Remove="@(Analyzer)" Condition="%(FileName) == 'Microsoft.Extensions.Logging.Generators'" /> | ||
| </ItemGroup> | ||
| </Target> |
There was a problem hiding this comment.
Can we add a TargetFramework check for this?
There was a problem hiding this comment.
Very valid point. Added the condition
|
Thank you @linkdotnet for completing this PR. Apologies it took a while to get it merged. |
3 participants
Essentially upgrade to .net6. Once .net6 is stable we only have to change the version in
Directory.Build.props.Resolves #148