Skip to content

Commit f6e6e5c

Browse files
authored
fix: add type="button" to TooltipTrigger in form components to prevent accidental submission (Dokploy#4422)
Co-authored-by: Maks Pikov <[email protected]>
1 parent b06138b commit f6e6e5c

5 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎apps/dokploy/components/dashboard/application/advanced/show-resources.tsx‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ export const ShowResources = ({ id, type }: Props) => {
224224
<FormLabel>Memory Limit</FormLabel>
225225
<TooltipProvider>
226226
<Tooltip delayDuration={0}>
227-
<TooltipTrigger>
227+
<TooltipTrigger type="button">
228228
<InfoIcon className="h-4 w-4 text-muted-foreground" />
229229
</TooltipTrigger>
230230
<TooltipContent>
@@ -263,7 +263,7 @@ export const ShowResources = ({ id, type }: Props) => {
263263
<FormLabel>Memory Reservation</FormLabel>
264264
<TooltipProvider>
265265
<Tooltip delayDuration={0}>
266-
<TooltipTrigger>
266+
<TooltipTrigger type="button">
267267
<InfoIcon className="h-4 w-4 text-muted-foreground" />
268268
</TooltipTrigger>
269269
<TooltipContent>
@@ -303,7 +303,7 @@ export const ShowResources = ({ id, type }: Props) => {
303303
<FormLabel>CPU Limit</FormLabel>
304304
<TooltipProvider>
305305
<Tooltip delayDuration={0}>
306-
<TooltipTrigger>
306+
<TooltipTrigger type="button">
307307
<InfoIcon className="h-4 w-4 text-muted-foreground" />
308308
</TooltipTrigger>
309309
<TooltipContent>
@@ -343,7 +343,7 @@ export const ShowResources = ({ id, type }: Props) => {
343343
<FormLabel>CPU Reservation</FormLabel>
344344
<TooltipProvider>
345345
<Tooltip delayDuration={0}>
346-
<TooltipTrigger>
346+
<TooltipTrigger type="button">
347347
<InfoIcon className="h-4 w-4 text-muted-foreground" />
348348
</TooltipTrigger>
349349
<TooltipContent>
@@ -379,7 +379,7 @@ export const ShowResources = ({ id, type }: Props) => {
379379
<FormLabel className="text-base">Ulimits</FormLabel>
380380
<TooltipProvider>
381381
<Tooltip delayDuration={0}>
382-
<TooltipTrigger>
382+
<TooltipTrigger type="button">
383383
<InfoIcon className="h-4 w-4 text-muted-foreground" />
384384
</TooltipTrigger>
385385
<TooltipContent className="max-w-xs">

‎apps/dokploy/components/dashboard/application/domains/handle-domain.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -806,7 +806,7 @@ export const AddDomain = ({ id, type, domainId = "", children }: Props) => {
806806
<FormLabel>Middlewares</FormLabel>
807807
<TooltipProvider>
808808
<Tooltip>
809-
<TooltipTrigger>
809+
<TooltipTrigger type="button">
810810
<div className="size-4 rounded-full bg-muted flex items-center justify-center text-[10px] font-bold">
811811
?
812812
</div>

‎apps/dokploy/components/dashboard/compose/general/generic/save-bitbucket-provider-compose.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ export const SaveBitbucketProviderCompose = ({ composeId }: Props) => {
422422
<FormLabel>Watch Paths</FormLabel>
423423
<TooltipProvider>
424424
<Tooltip>
425-
<TooltipTrigger>
425+
<TooltipTrigger type="button">
426426
<div className="size-4 rounded-full bg-muted flex items-center justify-center text-[10px] font-bold">
427427
?
428428
</div>

‎apps/dokploy/components/dashboard/compose/general/generic/save-github-provider-compose.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,7 @@ export const SaveGithubProviderCompose = ({ composeId }: Props) => {
449449
<FormLabel>Watch Paths</FormLabel>
450450
<TooltipProvider>
451451
<Tooltip>
452-
<TooltipTrigger>
452+
<TooltipTrigger type="button">
453453
<div className="size-4 rounded-full bg-muted flex items-center justify-center text-[10px] font-bold">
454454
?
455455
</div>

‎apps/dokploy/components/dashboard/compose/general/generic/save-gitlab-provider-compose.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ export const SaveGitlabProviderCompose = ({ composeId }: Props) => {
440440
<FormLabel>Watch Paths</FormLabel>
441441
<TooltipProvider>
442442
<Tooltip>
443-
<TooltipTrigger>
443+
<TooltipTrigger type="button">
444444
<div className="size-4 rounded-full bg-muted flex items-center justify-center text-[10px] font-bold">
445445
?
446446
</div>

0 commit comments

Comments
 (0)