Skip to content

Commit ec9dd28

Browse files
authored
fix(registry): preserve username case for ECR compatibility (Dokploy#4632) (Dokploy#4647)
Remove .toLowerCase() transform from registryUsernameSchema. AWS ECR requires the username to be exactly 'AWS' (uppercase) for authentication. Docker Hub usernames are case-insensitive for login, so preserving case is safe for all providers. Closes Dokploy#4632
1 parent e32133d commit ec9dd28

2 files changed

Lines changed: 80 additions & 6 deletions

File tree

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
1+
import { apiCreateRegistry, apiTestRegistry } from "@dokploy/server/db/schema";
2+
import { describe, expect, it } from "vitest";
3+
4+
describe("Registry Schema - Username case preservation (#4632)", () => {
5+
const validBase = {
6+
registryName: "AWS ECR",
7+
password: "dXNlcm5hbWU6cGFzc3dvcmQ=", // dummy base64 token
8+
registryUrl: "123456789.dkr.ecr.us-east-1.amazonaws.com",
9+
registryType: "cloud" as const,
10+
imagePrefix: null,
11+
};
12+
13+
it("should preserve uppercase username (AWS ECR requires 'AWS')", () => {
14+
const result = apiCreateRegistry.safeParse({
15+
...validBase,
16+
username: "AWS",
17+
});
18+
expect(result.success).toBe(true);
19+
if (result.success) {
20+
expect(result.data.username).toBe("AWS");
21+
}
22+
});
23+
24+
it("should not lowercase mixed-case usernames", () => {
25+
const result = apiCreateRegistry.safeParse({
26+
...validBase,
27+
username: "MyUser",
28+
});
29+
expect(result.success).toBe(true);
30+
if (result.success) {
31+
expect(result.data.username).toBe("MyUser");
32+
}
33+
});
34+
35+
it("should still trim whitespace from username", () => {
36+
const result = apiCreateRegistry.safeParse({
37+
...validBase,
38+
username: " AWS ",
39+
});
40+
expect(result.success).toBe(true);
41+
if (result.success) {
42+
expect(result.data.username).toBe("AWS");
43+
}
44+
});
45+
46+
it("should reject empty username", () => {
47+
const result = apiCreateRegistry.safeParse({
48+
...validBase,
49+
username: "",
50+
});
51+
expect(result.success).toBe(false);
52+
});
53+
54+
it("should also preserve case in apiTestRegistry", () => {
55+
const result = apiTestRegistry.safeParse({
56+
...validBase,
57+
username: "AWS",
58+
});
59+
expect(result.success).toBe(true);
60+
if (result.success) {
61+
expect(result.data.username).toBe("AWS");
62+
}
63+
});
64+
65+
it("should accept lowercase usernames too (backward compat)", () => {
66+
const result = apiCreateRegistry.safeParse({
67+
...validBase,
68+
username: "myuser",
69+
});
70+
expect(result.success).toBe(true);
71+
if (result.success) {
72+
expect(result.data.username).toBe("myuser");
73+
}
74+
});
75+
});

‎packages/server/src/db/schema/registry.ts‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,11 @@ export const registryRelations = relations(registry, ({ many }) => ({
4444
}),
4545
}));
4646

47-
// Image references require a lowercase namespace (e.g. Docker Hub username).
48-
const registryUsernameSchema = z
49-
.string()
50-
.trim()
51-
.min(1)
52-
.transform((s) => s.toLowerCase());
47+
// Registry usernames should NOT be lowercased.
48+
// Some registries (e.g. AWS ECR) require a specific case: the username must be
49+
// exactly "AWS" (uppercase) for ECR authentication. Docker Hub usernames are
50+
// case-insensitive for login, so preserving case is safe for all providers.
51+
const registryUsernameSchema = z.string().trim().min(1);
5352

5453
// Registry URLs must be hostname[:port] only — no shell metacharacters
5554
// Empty string is allowed (means default/Docker Hub registry)

0 commit comments

Comments
 (0)