Skip to content

Commit 91bcf88

Browse files
committed
fix: use updateJob to replace repeatable schedule job on update in cloud
Fixes Dokploy#5233. Updating an enabled schedule (cron/timezone change) called schedule() (create-backup), which only adds a new repeatable job and never removes the one registered under the old cron pattern, leaving an orphaned BullMQ job running in Redis indefinitely. Switched to updateJob() (update-backup), which looks up the currently registered repeatable pattern, removes it, then re-adds — same pattern already used in backup.ts for backups.
1 parent a63157c commit 91bcf88

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎apps/dokploy/server/api/routers/schedule.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import { asc, desc, eq } from "drizzle-orm";
2525
import { z } from "zod";
2626
import { audit } from "@/server/api/utils/audit";
2727
import { assertScheduledJobLimit } from "@/server/api/utils/plan-limits";
28-
import { removeJob, schedule } from "@/server/utils/backup";
28+
import { removeJob, schedule, updateJob } from "@/server/utils/backup";
2929
import { createTRPCRouter, protectedProcedure } from "../trpc";
3030

3131
export const scheduleRouter = createTRPCRouter({
@@ -130,7 +130,7 @@ export const scheduleRouter = createTRPCRouter({
130130

131131
if (IS_CLOUD) {
132132
if (updatedSchedule?.enabled) {
133-
schedule({
133+
await updateJob({
134134
scheduleId: updatedSchedule.scheduleId,
135135
type: "schedule",
136136
cronSchedule: updatedSchedule.cronExpression,

0 commit comments

Comments
 (0)