Skip to content

[panels] update attribute-template.json#207

Merged
valeriocos merged 1 commit intoBitergia:masterfrom
vchrombie:fix-204
Mar 31, 2020
Merged

[panels] update attribute-template.json#207
valeriocos merged 1 commit intoBitergia:masterfrom
vchrombie:fix-204

Conversation

@vchrombie
Copy link
Copy Markdown
Contributor

This PR updates the panels template for creating a dashboard during visualization.

Fixes #204

@vchrombie
Copy link
Copy Markdown
Contributor Author

vchrombie commented Mar 30, 2020

Hi @valeriocos
I completed the work as stated in the #204. I exported the updated dashboard using Kidash. I tested the change by deleting the dashboard and running the visualization again. Next time, the dashboard was generated without any trouble.

I have a few doubts though. Please review this PR when you have time.

Comment thread django-prosoul/prosoul/panels/templates/attribute-template.json Outdated
Comment thread django-prosoul/prosoul/panels/templates/attribute-template.json
Comment thread django-prosoul/prosoul/panels/templates/attribute-template.json Outdated
Comment thread django-prosoul/prosoul/panels/templates/attribute-template.json
Comment thread django-prosoul/prosoul/panels/templates/attribute-template.json Outdated
This commit updates the panels template for
creating a dashboard during visualization.

Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
@vchrombie
Copy link
Copy Markdown
Contributor Author

Done! 🎉

@valeriocos valeriocos self-requested a review March 31, 2020 13:49
Copy link
Copy Markdown
Contributor

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @vchrombie !

@valeriocos valeriocos merged commit c01766d into Bitergia:master Mar 31, 2020
@vchrombie vchrombie deleted the fix-204 branch April 8, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

index_pattern is not up to date in the templates

2 participants