[WIP] Clear all send and receive queues when node disconnects #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were only clearing vRecvMsg however there are two other queues vSendMsg and vRecvGetData which need to be cleared as well. A TRY_LOCK is used because of the potential for deadlock although not likely because at this point there should be no other contention.
ptschip
changed the title
Collaborator
Author
|
strange is fails on clearing vSend...i put this into WIP...i'll need to take a closer look at what's going on ...it should have been a simple PR but something else is going on here. |
Collaborator
Author
|
I'm starting to believe this is related to issue #314 Not the code here specifically but prior to this when the disconnects are being issued. I believe that vNodes is not locked properly, or rather the disconnects are being issued in the wrong manner. I"ll have more on this later. |
Collaborator
Author
|
closing for now, not sure this is necessary...PR 316 turns out to be the solution to the Invalid Message Start issue. Will re-assess this one at a later time. |
sickpig
pushed a commit
to sickpig/BitcoinUnlimited
that referenced
this pull request
Mar 12, 2018
HTTP Server cherries from Core: bitcoin/bitcoin#6719 - Make HTTP server shutdown more graceful bitcoin/bitcoin#6859 - http: Restrict maximum size of http + headers bitcoin/bitcoin#6990 - http: speed up shutdown bitcoin/bitcoin#7966 - http: Do a pending c++11 simplification handling work items bitcoin/bitcoin#8421 - httpserver: drop boost (#8023 dependency) bitcoin/bitcoin#11006 - Improve shutdown process
marlengit
pushed a commit
to marlengit/BitcoinUnlimited
that referenced
this pull request
Sep 25, 2018
HTTP Server cherries from Core: bitcoin/bitcoin#6719 - Make HTTP server shutdown more graceful bitcoin/bitcoin#6859 - http: Restrict maximum size of http + headers bitcoin/bitcoin#6990 - http: speed up shutdown bitcoin/bitcoin#7966 - http: Do a pending c++11 simplification handling work items bitcoin/bitcoin#8421 - httpserver: drop boost (#8023 dependency) bitcoin/bitcoin#11006 - Improve shutdown process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were only clearing vRecvMsg however there are
two other queues vSendMsg and vRecvGetData which need to be cleared
as well. A TRY_LOCK is used because of the potential for deadlock
although not likely because at this point there should be no other
contention.