[rpc] Allow fetching tx directly from specified block in getrawtransaction #1612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry picker note: Test case also includes code from other Bitcoin Core contributors.
…nsaction from a block directly.
sickpig
approved these changes
Mar 19, 2019
| uint256 &hashBlock, | ||
| bool fAllowSlow) | ||
| bool fAllowSlow, | ||
| const CBlockIndex *blockIndex) |
Collaborator
There was a problem hiding this comment.
nit: I found useful to add a something like that
const CBlockIndex *blockIndex /* = nullptr */)in function definition when it comes to optional parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitcoin/bitcoin#10275
bitcoin/bitcoin#9042
GetTransactionchanges are easier to review ignoring whitespace changes (add?w=1to the PR's URL)