Revert to original pre-SegWit max serialized blocksize values #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
OK we need to figure out something here. Did I broke the byte counting or did the byte counting used intentionally the segwit "virtual" size ? |
Contributor
Author
|
The previous (SegWit) byte counting in C++ code used total size of 4MB. The test was also adapted to use this max size. Then your code to remove SegWit changed the client back to 1MB, but the test was still using a daily quota based on 4MB blocks, so the node which should've disconnected never did (because it never reached quota), so the test failed because the node was still there.
|
Member
|
Yes I see. This is ridiculous. |
lateminer
pushed a commit
to lateminer/bitcoin-abc
that referenced
this pull request
Apr 1, 2018
Update Bitcoin-ABC core
Mengerian
pushed a commit
to Mengerian/bitcoin-abc
that referenced
this pull request
Oct 31, 2019
johann-sys
added a commit
to johann-sys/bitcoin-abc
that referenced
this pull request
May 15, 2025
logoMainnet Explorer learn more about eCash ! block height/hash, txid, address Address ecash:qz60j37wmr0wv2k9ksz5e4qkjdzgxggg3sr98q45ug Details JSON Summary Script Public Key 76a914b4f947ced8dee62ac5b4054cd41693448321088c88ac Balance 0 Transactions 2 QR Code ecash:qz60j37wmr0wv2k9ksz5e4qkjdzgxggg3sr98q45ug Scripthash 6b7253cd13966210f51a0482486181fb036f639aa1f2fbf6ddd0daee039d4450 Is Valid? Is Script? 2 Transactions Newest First Bitcoin-ABC#2– 0357c59fffffd39cd438db127a39e88887ab818b7b9933db03ba7e44dc73a98f -552,510.39XEC 6/2, 2014 19:24 (10y, 11mo, 13d ago) > Input #0 / 0 p2pkhe4a57a901c8d13e411ad47024… #0 (addr:ecash:qz60j37wmr0wv2k9ksz5e4qkjdzgxggg3sr98q45ug 552,510.39XEC Total Input: 552,510.39XEC < Output #0 / 1 p2pkh ecash:qzgyfwdkwn9zx6h9vvl0tafupvk2drkdtg0kzut2al 204,747.39XEC < Output Bitcoin-ABC#1 / 1 p2pkh ecash:qzq4es9v7eq2wfm6rxwhpazaryes4xyedsfpjlylcd 347,763XEC Total Output: 552,510.39XEC Bitcoin-ABC#1– e4a57a901c8d13e411ad47024dcba3e04f268c99c6fc1e99f0bf14afc2e81c7f +552,510.39XEC 5/19, 2014 19:36 (10y, 11mo, 27d ago) > Input #0 / 18 p2pkh01f5cb95681c922d44ae517da… Bitcoin-ABC#1 (addr:ecash:qqc24zdvcnjhnusda0jkvrrgmkg0jnl88vg4txjsg5 0.01XEC > Input Bitcoin-ABC#1 / 18 p2pkh6e8f883eb799a9a286fe492a3… #0 (addr:ecash:qr0tjhmsrgjsf3k72xdtqv7flxq750x645z0wwxpmq 40.47XEC > Input Bitcoin-ABC#2 / 18 p2pkh901bde191beb61d2fc5bf480c… Bitcoin-ABC#1 (addr:ecash:qrjckd8ep6grzchnsv9gcdzwcpwqjazn6unlutuff9 0.01XEC > Input Bitcoin-ABC#3 / 18 p2pkh8cab265e1896f173757325295… #0 (addr:ecash:qqh24fuuud0yp5pn2q4spdh8yfwd8kskzyhtmgu8c6 53,927.28XEC > Input Bitcoin-ABC#4 / 18 p2pkhbb79adc9ad5e696ed8fe08f74… Bitcoin-ABC#1 (addr:ecash:qqe3egddd4s95glp0kczh02evv3q326pvq9r25j3jn 0.01XEC > Input Bitcoin-ABC#5 / 18 p2pkh4dacaefb3d43daed074189358… Bitcoin-ABC#1 (addr:ecash:qrrdyutsjnr5xy7fd60dgra9aw8jc5gjdy00exz55l 0.01XEC > Input Bitcoin-ABC#6 / 18 p2pkh65f5d4d7b80e0cd4d4d477b65… Bitcoin-ABC#1 (addr:ecash:qrgs5rvlxee0f4cayf9tcslzdn3h7kky95jvyljnqq 0.01XEC > Input Bitcoin-ABC#7 / 18 p2pkhf183d53245ab3a17a3278e696… #0 (addr:ecash:qrjckd8ep6grzchnsv9gcdzwcpwqjazn6unlutuff9 9,438XEC > Input Bitcoin-ABC#8 / 18 p2pkh7f6ce8e4e912b8da7da9f43ac… Bitcoin-ABC#1 (addr:ecash:qzzy34srdrgtnzqcy3adgcxh278x78mwmuya540hkx 0.01XEC > Input Bitcoin-ABC#9 / 18 p2pkh3922dd199e8901bc7dffc06fe… #0 (addr:ecash:qpycut36dx0j03us0c4l3hn9cfhyclu9e5nxxhz3dg 0.01XEC > Input Bitcoin-ABC#10 / 18 p2pkhd00af226755d2f6f78c3c213d… Bitcoin-ABC#1 (addr:ecash:qpnyhed8vzp34mtg63cxxy6cdjcsdcnazsff2sylqt 0.01XEC > Input Bitcoin-ABC#11 / 18 p2pkha04e516237bc80d3716a174e0… #0 (addr:ecash:qptuamelkkux8r5uuv8uqlzmn0ag2542fydyslz7s5 399,970XEC > Input Bitcoin-ABC#12 / 18 p2pkhd63ccab1d9b1fe1788d21d38b… Bitcoin-ABC#1 (addr:ecash:qryd3ex3zq860sqzney5guqlf5r2y8huzcy0ng8uuv 5.13XEC > Input Bitcoin-ABC#13 / 18 p2pkh0fe15b8cc74cfd189ca866132… Bitcoin-ABC#16 (addr:ecash:qrjckd8ep6grzchnsv9gcdzwcpwqjazn6unlutuff9 80XEC > Input Bitcoin-ABC#14 / 18 p2pkh679fde36f4059292df243e074… Bitcoin-ABC#1 (addr:ecash:qzuch5gavmtnl7ql53xhswquhu8jz6p7z5jfej3nam 0.01XEC > Input Bitcoin-ABC#15 / 18 p2pkha2a641d13a94a3dcc77cacaa8… Bitcoin-ABC#6 (addr:ecash:qrjckd8ep6grzchnsv9gcdzwcpwqjazn6unlutuff9 400XEC > Input Bitcoin-ABC#16 / 18 p2pkh46f3140ef52750b7c380e8f91… Bitcoin-ABC#200 (addr:ecash:qrjckd8ep6grzchnsv9gcdzwcpwqjazn6unlutuff9 20.68XEC > Input Bitcoin-ABC#17 / 18 p2pkhafa535d4b4e2345cf7fce38f9… Bitcoin-ABC#46 (addr:ecash:qrjckd8ep6grzchnsv9gcdzwcpwqjazn6unlutuff9 96.45XEC > Input Bitcoin-ABC#18 / 18 p2pkh6ab5f652b42b27703f5c1fc34… Bitcoin-ABC#1 (addr:ecash:qzrn4d90fw6029pmdn95r5wy68z4638luyv5rnl303 88,932.29XEC Total Input: 552,910.39XEC < Output #0 / 0 p2pkh ecash:qz60j37wmr0wv2k9ksz5e4qkjdzgxggg3sr98q45ug 552,510.39XEC Total Output: 552,510.39XEC hosted by bitcoinabc.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the problem was not in the client after all, only in the test which contained adaptations based on SegWit max serialized block size.