@@ -98,22 +98,22 @@ BOOST_AUTO_TEST_CASE(addrman_simple)
9898 CNetAddr source = ResolveIP (" 252.2.2.2" );
9999
100100 // Test: Does Addrman respond correctly when empty.
101- BOOST_CHECK_EQUAL (addrman.size (), 0 );
101+ BOOST_CHECK_EQUAL (addrman.size (), 0U );
102102 CAddrInfo addr_null = addrman.Select ();
103103 BOOST_CHECK_EQUAL (addr_null.ToString (), " [::]:0" );
104104
105105 // Test: Does Addrman::Add work as expected.
106106 CService addr1 = ResolveService (" 250.1.1.1" , 8333 );
107107 BOOST_CHECK (addrman.Add (CAddress (addr1, NODE_NONE), source));
108- BOOST_CHECK_EQUAL (addrman.size (), 1 );
108+ BOOST_CHECK_EQUAL (addrman.size (), 1U );
109109 CAddrInfo addr_ret1 = addrman.Select ();
110110 BOOST_CHECK_EQUAL (addr_ret1.ToString (), " 250.1.1.1:8333" );
111111
112112 // Test: Does IP address deduplication work correctly.
113113 // Expected dup IP should not be added.
114114 CService addr1_dup = ResolveService (" 250.1.1.1" , 8333 );
115115 BOOST_CHECK (!addrman.Add (CAddress (addr1_dup, NODE_NONE), source));
116- BOOST_CHECK_EQUAL (addrman.size (), 1 );
116+ BOOST_CHECK_EQUAL (addrman.size (), 1U );
117117
118118
119119 // Test: New table has one addr and we add a diff addr we should
@@ -128,7 +128,7 @@ BOOST_AUTO_TEST_CASE(addrman_simple)
128128
129129 // Test: AddrMan::Clear() should empty the new table.
130130 addrman.Clear ();
131- BOOST_CHECK_EQUAL (addrman.size (), 0 );
131+ BOOST_CHECK_EQUAL (addrman.size (), 0U );
132132 CAddrInfo addr_null2 = addrman.Select ();
133133 BOOST_CHECK_EQUAL (addr_null2.ToString (), " [::]:0" );
134134
@@ -146,23 +146,23 @@ BOOST_AUTO_TEST_CASE(addrman_ports)
146146
147147 CNetAddr source = ResolveIP (" 252.2.2.2" );
148148
149- BOOST_CHECK_EQUAL (addrman.size (), 0 );
149+ BOOST_CHECK_EQUAL (addrman.size (), 0U );
150150
151151 // Test 7; Addr with same IP but diff port does not replace existing addr.
152152 CService addr1 = ResolveService (" 250.1.1.1" , 8333 );
153153 addrman.Add (CAddress (addr1, NODE_NONE), source);
154- BOOST_CHECK_EQUAL (addrman.size (), 1 );
154+ BOOST_CHECK_EQUAL (addrman.size (), 1U );
155155
156156 CService addr1_port = ResolveService (" 250.1.1.1" , 8334 );
157157 addrman.Add (CAddress (addr1_port, NODE_NONE), source);
158- BOOST_CHECK_EQUAL (addrman.size (), 1 );
158+ BOOST_CHECK_EQUAL (addrman.size (), 1U );
159159 CAddrInfo addr_ret2 = addrman.Select ();
160160 BOOST_CHECK_EQUAL (addr_ret2.ToString (), " 250.1.1.1:8333" );
161161
162162 // Test: Add same IP but diff port to tried table, it doesn't get added.
163163 // Perhaps this is not ideal behavior but it is the current behavior.
164164 addrman.Good (CAddress (addr1_port, NODE_NONE));
165- BOOST_CHECK_EQUAL (addrman.size (), 1 );
165+ BOOST_CHECK_EQUAL (addrman.size (), 1U );
166166 bool newOnly = true ;
167167 CAddrInfo addr_ret3 = addrman.Select (newOnly);
168168 BOOST_CHECK_EQUAL (addr_ret3.ToString (), " 250.1.1.1:8333" );
@@ -178,22 +178,22 @@ BOOST_AUTO_TEST_CASE(addrman_select)
178178 // Test: Select from new with 1 addr in new.
179179 CService addr1 = ResolveService (" 250.1.1.1" , 8333 );
180180 addrman.Add (CAddress (addr1, NODE_NONE), source);
181- BOOST_CHECK_EQUAL (addrman.size (), 1 );
181+ BOOST_CHECK_EQUAL (addrman.size (), 1U );
182182
183183 bool newOnly = true ;
184184 CAddrInfo addr_ret1 = addrman.Select (newOnly);
185185 BOOST_CHECK_EQUAL (addr_ret1.ToString (), " 250.1.1.1:8333" );
186186
187187 // Test: move addr to tried, select from new expected nothing returned.
188188 addrman.Good (CAddress (addr1, NODE_NONE));
189- BOOST_CHECK_EQUAL (addrman.size (), 1 );
189+ BOOST_CHECK_EQUAL (addrman.size (), 1U );
190190 CAddrInfo addr_ret2 = addrman.Select (newOnly);
191191 BOOST_CHECK_EQUAL (addr_ret2.ToString (), " [::]:0" );
192192
193193 CAddrInfo addr_ret3 = addrman.Select ();
194194 BOOST_CHECK_EQUAL (addr_ret3.ToString (), " 250.1.1.1:8333" );
195195
196- BOOST_CHECK_EQUAL (addrman.size (), 1 );
196+ BOOST_CHECK_EQUAL (addrman.size (), 1U );
197197
198198
199199 // Add three addresses to new table.
@@ -218,14 +218,14 @@ BOOST_AUTO_TEST_CASE(addrman_select)
218218 addrman.Good (CAddress (addr7, NODE_NONE));
219219
220220 // Test: 6 addrs + 1 addr from last test = 7.
221- BOOST_CHECK_EQUAL (addrman.size (), 7 );
221+ BOOST_CHECK_EQUAL (addrman.size (), 7U );
222222
223223 // Test: Select pulls from new and tried regardless of port number.
224224 std::set<uint16_t > ports;
225225 for (int i = 0 ; i < 20 ; ++i) {
226226 ports.insert (addrman.Select ().GetPort ());
227227 }
228- BOOST_CHECK_EQUAL (ports.size (), 3 );
228+ BOOST_CHECK_EQUAL (ports.size (), 3U );
229229}
230230
231231BOOST_AUTO_TEST_CASE (addrman_new_collisions)
@@ -234,7 +234,7 @@ BOOST_AUTO_TEST_CASE(addrman_new_collisions)
234234
235235 CNetAddr source = ResolveIP (" 252.2.2.2" );
236236
237- BOOST_CHECK_EQUAL (addrman.size (), 0 );
237+ BOOST_CHECK_EQUAL (addrman.size (), 0U );
238238
239239 for (unsigned int i = 1 ; i < 18 ; i++) {
240240 CService addr = ResolveService (" 250.1.1." + std::to_string (i));
@@ -247,11 +247,11 @@ BOOST_AUTO_TEST_CASE(addrman_new_collisions)
247247 // Test: new table collision!
248248 CService addr1 = ResolveService (" 250.1.1.18" );
249249 addrman.Add (CAddress (addr1, NODE_NONE), source);
250- BOOST_CHECK_EQUAL (addrman.size (), 17 );
250+ BOOST_CHECK_EQUAL (addrman.size (), 17U );
251251
252252 CService addr2 = ResolveService (" 250.1.1.19" );
253253 addrman.Add (CAddress (addr2, NODE_NONE), source);
254- BOOST_CHECK_EQUAL (addrman.size (), 18 );
254+ BOOST_CHECK_EQUAL (addrman.size (), 18U );
255255}
256256
257257BOOST_AUTO_TEST_CASE (addrman_tried_collisions)
@@ -260,7 +260,7 @@ BOOST_AUTO_TEST_CASE(addrman_tried_collisions)
260260
261261 CNetAddr source = ResolveIP (" 252.2.2.2" );
262262
263- BOOST_CHECK_EQUAL (addrman.size (), 0 );
263+ BOOST_CHECK_EQUAL (addrman.size (), 0U );
264264
265265 for (unsigned int i = 1 ; i < 80 ; i++) {
266266 CService addr = ResolveService (" 250.1.1." + std::to_string (i));
@@ -274,18 +274,18 @@ BOOST_AUTO_TEST_CASE(addrman_tried_collisions)
274274 // Test: tried table collision!
275275 CService addr1 = ResolveService (" 250.1.1.80" );
276276 addrman.Add (CAddress (addr1, NODE_NONE), source);
277- BOOST_CHECK_EQUAL (addrman.size (), 79 );
277+ BOOST_CHECK_EQUAL (addrman.size (), 79U );
278278
279279 CService addr2 = ResolveService (" 250.1.1.81" );
280280 addrman.Add (CAddress (addr2, NODE_NONE), source);
281- BOOST_CHECK_EQUAL (addrman.size (), 80 );
281+ BOOST_CHECK_EQUAL (addrman.size (), 80U );
282282}
283283
284284BOOST_AUTO_TEST_CASE (addrman_find)
285285{
286286 CAddrManTest addrman;
287287
288- BOOST_CHECK_EQUAL (addrman.size (), 0 );
288+ BOOST_CHECK_EQUAL (addrman.size (), 0U );
289289
290290 CAddress addr1 = CAddress (ResolveService (" 250.1.2.1" , 8333 ), NODE_NONE);
291291 CAddress addr2 = CAddress (ResolveService (" 250.1.2.1" , 9999 ), NODE_NONE);
@@ -318,7 +318,7 @@ BOOST_AUTO_TEST_CASE(addrman_create)
318318{
319319 CAddrManTest addrman;
320320
321- BOOST_CHECK_EQUAL (addrman.size (), 0 );
321+ BOOST_CHECK_EQUAL (addrman.size (), 0U );
322322
323323 CAddress addr1 = CAddress (ResolveService (" 250.1.2.1" , 8333 ), NODE_NONE);
324324 CNetAddr source1 = ResolveIP (" 250.1.2.1" );
@@ -338,7 +338,7 @@ BOOST_AUTO_TEST_CASE(addrman_delete)
338338{
339339 CAddrManTest addrman;
340340
341- BOOST_CHECK_EQUAL (addrman.size (), 0 );
341+ BOOST_CHECK_EQUAL (addrman.size (), 0U );
342342
343343 CAddress addr1 = CAddress (ResolveService (" 250.1.2.1" , 8333 ), NODE_NONE);
344344 CNetAddr source1 = ResolveIP (" 250.1.2.1" );
@@ -347,9 +347,9 @@ BOOST_AUTO_TEST_CASE(addrman_delete)
347347 addrman.Create (addr1, source1, &nId);
348348
349349 // Test: Delete should actually delete the addr.
350- BOOST_CHECK_EQUAL (addrman.size (), 1 );
350+ BOOST_CHECK_EQUAL (addrman.size (), 1U );
351351 addrman.Delete (nId);
352- BOOST_CHECK_EQUAL (addrman.size (), 0 );
352+ BOOST_CHECK_EQUAL (addrman.size (), 0U );
353353 CAddrInfo* info2 = addrman.Find (addr1);
354354 BOOST_CHECK (info2 == nullptr );
355355}
@@ -360,9 +360,9 @@ BOOST_AUTO_TEST_CASE(addrman_getaddr)
360360
361361 // Test: Sanity check, GetAddr should never return anything if addrman
362362 // is empty.
363- BOOST_CHECK_EQUAL (addrman.size (), 0 );
363+ BOOST_CHECK_EQUAL (addrman.size (), 0U );
364364 std::vector<CAddress> vAddr1 = addrman.GetAddr ();
365- BOOST_CHECK_EQUAL (vAddr1.size (), 0 );
365+ BOOST_CHECK_EQUAL (vAddr1.size (), 0U );
366366
367367 CAddress addr1 = CAddress (ResolveService (" 250.250.2.1" , 8333 ), NODE_NONE);
368368 addr1.nTime = GetAdjustedTime (); // Set time so isTerrible = false
@@ -385,12 +385,12 @@ BOOST_AUTO_TEST_CASE(addrman_getaddr)
385385 addrman.Add (addr5, source1);
386386
387387 // GetAddr returns 23% of addresses, 23% of 5 is 1 rounded down.
388- BOOST_CHECK_EQUAL (addrman.GetAddr ().size (), 1 );
388+ BOOST_CHECK_EQUAL (addrman.GetAddr ().size (), 1U );
389389
390390 // Test: Ensure GetAddr works with new and tried addresses.
391391 addrman.Good (CAddress (addr1, NODE_NONE));
392392 addrman.Good (CAddress (addr2, NODE_NONE));
393- BOOST_CHECK_EQUAL (addrman.GetAddr ().size (), 1 );
393+ BOOST_CHECK_EQUAL (addrman.GetAddr ().size (), 1U );
394394
395395 // Test: Ensure GetAddr still returns 23% when addrman has many addrs.
396396 for (unsigned int i = 1 ; i < (8 * 256 ); i++) {
@@ -409,9 +409,9 @@ BOOST_AUTO_TEST_CASE(addrman_getaddr)
409409
410410 size_t percent23 = (addrman.size () * 23 ) / 100 ;
411411 BOOST_CHECK_EQUAL (vAddr.size (), percent23);
412- BOOST_CHECK_EQUAL (vAddr.size (), 461 );
412+ BOOST_CHECK_EQUAL (vAddr.size (), 461U );
413413 // (Addrman.size() < number of addresses added) due to address collisions.
414- BOOST_CHECK_EQUAL (addrman.size (), 2006 );
414+ BOOST_CHECK_EQUAL (addrman.size (), 2006U );
415415}
416416
417417
@@ -454,7 +454,7 @@ BOOST_AUTO_TEST_CASE(caddrinfo_get_tried_bucket)
454454 }
455455 // Test: IP addresses in the same group (\16 prefix for IPv4) should
456456 // never get more than 8 buckets
457- BOOST_CHECK_EQUAL (buckets.size (), 8 );
457+ BOOST_CHECK_EQUAL (buckets.size (), 8U );
458458
459459 buckets.clear ();
460460 for (int j = 0 ; j < 255 ; j++) {
@@ -466,7 +466,7 @@ BOOST_AUTO_TEST_CASE(caddrinfo_get_tried_bucket)
466466 }
467467 // Test: IP addresses in the different groups should map to more than
468468 // 8 buckets.
469- BOOST_CHECK_EQUAL (buckets.size (), 160 );
469+ BOOST_CHECK_EQUAL (buckets.size (), 160U );
470470}
471471
472472BOOST_AUTO_TEST_CASE (caddrinfo_get_new_bucket)
@@ -506,7 +506,7 @@ BOOST_AUTO_TEST_CASE(caddrinfo_get_new_bucket)
506506 }
507507 // Test: IP addresses in the same group (\16 prefix for IPv4) should
508508 // always map to the same bucket.
509- BOOST_CHECK_EQUAL (buckets.size (), 1 );
509+ BOOST_CHECK_EQUAL (buckets.size (), 1U );
510510
511511 buckets.clear ();
512512 for (int j = 0 ; j < 4 * 255 ; j++) {
0 commit comments