A new engine for Rust Bitcoin script evaluation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I want to point out that there is a material change in the engine. Previously, the stat will consider the total number of bytes in the stack as well as the max length of a single stack element: let stack_size = self.stack.iter().chain(self.altstack.iter()).map(|i| i.len()).sum();
self.stats.max_stack_bytes = cmp::max(self.stats.max_stack_bytes, stack_size);
// NB since every item that ever gets on the altstack first gets on the stack,
// we don't have to look at the altstack here
let max_item = self.stack.iter().map(|i| i.len()).max().unwrap_or(0);
self.stats.max_stack_item_size = cmp::max(self.stats.max_stack_item_size, max_item);I think these two have caused slowdown and probably should be removed. Later, they may be substituted with a new method that does the stat when needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This engine is intended to improve the performance of script evaluation.
The main idea is to default the stack into a stack that represents signed 32-bit integers.
Some functions and interfaces need to be changed as well.