TMUL Integration into Groth16 Verifier #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y_prevent_overflow
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes the following:
integrates the new tmul function into Groth16 verifier and all the functions that it uses. Hinted Groth16 Verifier is 1.43 Gb instead of 2.65 Gb. To do that, we introduce modified functions that expect inputs in the standard form instead of Montgomery since tmul expects that. These functions also returns the list of hints.
improves newly introduced
limb_add_with_carry_prevent_overflowandlimb_double_with_carry_prevent_overflowfunctions which results in around 1 Kb improvement in tmul.adds hinted Fq.inv() so closes Compute inverses using a hint #72
fixes BigIntImpl::is_positive() because it was considering 0 as positive.
separates N_WINDOW const in tmul because it should be two separate consts for different MOD_WIDTH and VAR_WIDTH.
Note: The original tmul and also this one currently do not not work with different MOD_WIDTH and VAR_WIDTH. You need to select the same MOD_WIDTH and VAR_WIDTH, for example (4, 4) is the best option in terms of script size currently.