Refactor - Remove montgomery functions #184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…respective structs
Contributor
|
will review after merge conflicts have been fixed :) thanks |
Collaborator
Author
|
#188 replaces this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes montgomery functions and deletes the "_not_montgomery" suffix from those that are not montgomery. As the effect of it, some unhinted functions, starting with Fq.mul, Fq.square, Fq.inv, are removed. Also, removes u29x9 and u32x8 as they are no longer used. Also removes G1Projective.
Note: It is better to merge this after #177 since this is on top of it.