Skip to content

fix: ensure same line coeff in g2 affine dbl and add #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lucidLuckylee merged 1 commit into from
Jan 2, 2025
Merged

fix: ensure same line coeff in g2 affine dbl and add #162

lucidLuckylee merged 1 commit into from
Jan 2, 2025

Conversation

@manishbista28
Copy link
Contributor

@manishbista28 manishbista28 commented Dec 17, 2024

Fixes issues with separate line coefficients being used in g2 affine point operation functions.
Tests included.

@manishbista28
Copy link
Contributor Author

manishbista28 commented Dec 17, 2024

Remaining:
Apply necessary changes to test_hinted_quad_miller_loop_with_c_wi.
Left because the test hasn't been functional for some time now.

@manishbista28 manishbista28 marked this pull request as draft December 17, 2024 14:31
@manishbista28 manishbista28 marked this pull request as ready for review December 17, 2024 14:35
@manishbista28
Copy link
Contributor Author

manishbista28 commented Dec 17, 2024

requesting bitlayer team @wz14 to review changes to chunk_non_fixed_point.rs specifically.
the tests in that file, assertion and disprove is working though.

@freddi8e
Copy link
Contributor

freddi8e commented Dec 18, 2024

requesting bitlayer team @wz14 to review changes to chunk_non_fixed_point.rs specifically. the tests in that file, assertion and disprove is working though.

It seems to solve same issue as issue 157.
Actually, we are fixing the issue 157 and will finish soon; in the fix, the non-fixed point coefficients is committed by bit commitment, which can ensure same value is used by check_q4 and accumulator.

@manishbista28 manishbista28 mentioned this pull request Dec 19, 2024
Merged
@Hakkush-07
Copy link
Collaborator

Hakkush-07 commented Dec 20, 2024

This is extending the work of ensuring same hints in G1Affine to G2Affine. It looks good to me.

@lucidLuckylee lucidLuckylee merged commit c2f79dc into BitVM:main Jan 2, 2025
@manishbista28 manishbista28 mentioned this pull request Jan 3, 2025
Closed
lucidLuckylee pushed a commit that referenced this pull request Jan 6, 2025
@manishbista28 @lucidLuckylee
fix: issues with g2 affine dbl and add (#162)
bb9f341 
Co-authored-by: Manish Bista <[email protected]>
@manishbista28 manishbista28 deleted the fix/issue_hinted_fn_dbl_add branch February 23, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@manishbista28 @freddi8e @Hakkush-07 @lucidLuckylee