fix(blake3_u4): issue with insufficient size of precompute table #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@manishbista28 Nice catch! |
jonasmartin
reviewed
Dec 15, 2024
Contributor
|
Nice work! Thank you for the PR! |
stillsaiko
pushed a commit
that referenced
this pull request
Dec 16, 2024
* fix(blake3_u4): issue with insufficient size of precompute table * chore: use get_script len function --------- Co-authored-by: Manish Bista <[email protected]>
stillsaiko
added a commit
that referenced
this pull request
Dec 16, 2024
* Chore `fp_lc_mul` clippy lint `reversed_empty_ranges` * Chore `#![allow(clippy::*)]` * Chore `.div_ceil()` in `fq.rs` * fix(blake3_u4): issue with insufficient size of precompute table (#154) * fix(blake3_u4): issue with insufficient size of precompute table * chore: use get_script len function --------- Co-authored-by: Manish Bista <[email protected]> * fix: issue where precompute p function bakes runtime input (#155) * fix: issue where precompute p bakes runtime input * chore: unchanged gitignore --------- Co-authored-by: Manish Bista <[email protected]> --------- Co-authored-by: manishbista28 <[email protected]> Co-authored-by: Manish Bista <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current blake3_u4 implementation has an issue which generates incorrect output hash for some input message.
blake3_u4 operates over nibbles and looks up modulo and quotient values in a precompute table. The size of table depends upon the range of input index.
For example if you want to sum three number 0xfe + 0xff + 0xff, the impl proceeds in following steps:
The fix adds an extra element on the precompute table making it of size 48. Since blake3_u4 only adds 3 elements at max, this new precompute table length suffices for the entire range of input.
A test has been added which fails if the fix is not present.