Skip to content

refactor: separate bn254/curves into bn254/curves_g1 and bn254/curves_g2  #171

@manishbista28

Description

@manishbista28

As a refactor, I'd like to suggest splitting functions in the file bn254/curves.rs into bn254/curves_g1.rs and bn254/curves_g2.rs each of which should include their respective methods -- both affine and projective.

Additionally, a lot of the core point operation functions that one may expect as implementations of these structs have been lumped together inside in utils.rs. For example,

  • hinted_affine_double_line
  • hinted_affine_add_line
  • hinted_check_tangent_line
  • hinted_check_chord_line, etc.

A clearer separation might help navigate codebase down the line.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions