Conversation
|
I am setting the PR to merge into |
alinaliBQ
force-pushed
the
sql-driver-connect
branch
from
ab159f4 to
2779187
Compare
alinaliBQ
force-pushed
the
sql-driver-connect-dsn-window
branch
3 times, most recently
from
2b39bca to
96d283b
Compare
alinaliBQ
force-pushed
the
sql-driver-connect
branch
from
c98f368 to
ce4a14e
Compare
alinaliBQ
force-pushed
the
sql-driver-connect-dsn-window
branch
from
96d283b to
d23e867
Compare
alinaliBQ
force-pushed
the
sql-driver-connect-dsn-window
branch
from
d23e867 to
5e005da
Compare
There was a problem hiding this comment.
Is HY008 right? That's for query cancellation usually.
Aside from that, I think if the user cancels the connection dialog the driver is supposed to return SQL_NO_DATA or SQL_NEED_DATA rather than an error. Please check this.
There was a problem hiding this comment.
Probably should log if there's a cancelled dialog though.
There was a problem hiding this comment.
Hmm you're right, HY008 is what Apache Ignite passed (link) but the spec does say that HY008 is for cancelled queries. And the spec does say that SQL_NO_DATA should be returned, there seems to be no error message for canceled dialog actually, so I have removed the throw.
There was a problem hiding this comment.
And yes driver logging would be useful. However we haven't enabled logging yet (it is planned for milestone 2), so I have added a todo to add log here after it is enabled.
alinaliBQ
force-pushed
the
sql-driver-connect-dsn-window
branch
2 times, most recently
from
f957577 to
56b3ad0
Compare
alinaliBQ
force-pushed
the
sql-driver-connect-dsn-window
branch
from
56b3ad0 to
95c0c3d
Compare
2 participants
DSN window implementation developed according to driver guidelines spec