Merged
Conversation
Member
Author
|
To avoid reviewers create AWS directories on their own, this is what the output looks like:
|
Collaborator
|
@bishopfaure, @dbravo-bishopfox - This looks great. Ready to merge into main! I'll push create a PR for my stuff tomorrow and we will have all the new stuff in main and can make a release tomorrow! |
dbravo-bishopfox
approved these changes
Apr 16, 2024
Contributor
dbravo-bishopfox
left a comment
dbravo-bishopfox
left a comment
There was a problem hiding this comment.
lgtm! & Seth :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds "directoryservice" support into
cloudfoxand enables users to display directories that exist in the AWS space. Beyond a simple list of data, the module formats the trust information in a nice format that easily understandable.I've been myself in a situation where we missed an AWS-managed directory during a CPT/IPT mixed engagement, and knowing that this domain existed and had certain trusts could likely have helped us to demonstrate a slightly bigger impact and highly additional escalation paths.