Agents/media: restore agent-scoped and iMessage attachment roots#79
Open
BingqingLyu wants to merge 10 commits into
Open
Agents/media: restore agent-scoped and iMessage attachment roots#79BingqingLyu wants to merge 10 commits into
BingqingLyu wants to merge 10 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentSessionKey, and the image tool could not read iMessage attachments after 2026.2.26 becauseattachmentRootsnever reached its local allowlist.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
imagetool can read iMessage attachment paths allowed by configuredattachmentRoots, including wildcard roots such as/Users/*/Library/Messages/Attachments.CHANGELOG.mdnow includes entries for both fixes with thanks to @ravz, @macminikenny1, and @vincentkoc.Security Impact (required)
NoNoNoNoNoRepro + Verification
Environment
channels.imessage.attachmentRootsSteps
agentSessionKey.attachmentRoots, send an attachment, and use theimagetool on that local path./tmp/*/Library/Messages/Attachments.Expected
Actual
path-not-allowed, iMessage attachments were rejected by the image tool, and wildcard local roots never matched.Evidence
Human Verification (required)
What you personally verified (not just CI), and how:
Compatibility / Migration
YesNoNoFailure Recovery (if this breaks)
message-tool,image-tool,local-roots, andweb/media.src/agents/tools/message-tool.ts,src/agents/openclaw-tools.ts,src/agents/tools/image-tool.ts,src/media/local-roots.ts,src/web/media.tsRisks and Mitigations