Preserve disk config during runtime snapshot writeback#593
Open
BingqingLyu wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a config writeback bug where
writeConfigFile(loadConfig())could drop keys that were added on disk after the active runtime snapshot was created.In practice that meant an explicit top-level
session.dmScopecould disappear during gateway-triggered writebacks, which matches the dmScope persistence bug reported in openclaw#15146.Root cause
src/config/io.tsprojected runtime-derived configs back ontoruntimeConfigSourceSnapshotbefore persisting them.When that source snapshot was stale, any newer disk-only keys were missing from the projection base, so the follow-up write deleted them.
This PR now:
session.dmScopebeing stripped by a stale runtime snapshotTesting
corepack pnpm vitest src/config/io.runtime-snapshot-write.test.tscorepack pnpm vitest src/config/io.owner-display-secret.test.tscorepack pnpm vitest src/config/env-preserve-io.test.tsFixes openclaw#15146.