fix(gateway): use account-scoped reload for channel account changes#517
Open
BingqingLyu wants to merge 1 commit into
Open
fix(gateway): use account-scoped reload for channel account changes#517BingqingLyu wants to merge 1 commit into
BingqingLyu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use account-scoped hot reload for config changes under:
channels.<channel>.accounts.<accountId>.*instead of always restarting the entire channel.
What changed
GatewayReloadPlanbuildGatewayReloadPlanstopChannel(channelId, accountId)startChannel(channelId, accountId)Why
The gateway reload framework already has account-scoped channel lifecycle support, but hot reload planning previously collapsed all matching channel config changes into full channel restarts.
That makes account-only config edits broader and more disruptive than necessary.
Tests
Added coverage for:
Validated with:
corepack pnpm exec vitest run src/gateway/config-reload.test.ts src/gateway/server.reload.test.tsScope / non-goals
This change is intentionally narrow.
It does not redesign active reply draining, typing lifecycle coordination, or provider-specific recovery behavior.
Closes openclaw#43935