fix(systemd): reconcile managed-env unit migrations#2494
Open
BingqingLyu wants to merge 1 commit into
Open
Conversation
BingqingLyu
added
conflicting-group-1
Owner
Author
|
| Function | File | Also modified by |
|---|---|---|
expectExecStartWithoutEnvironment |
src/daemon/systemd.test.ts |
#2513 |
stageSystemdService |
src/daemon/systemd.ts |
#2513 |
Recommendation: Coordinate with #2513 before merging.
Auto-detected by codegraph — a code graph analysis tool built on neug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#66295onto currentmainExecStart=is missing, and reconcile staleWorkingDirectory=in-place instead of leavingCHDIRfailures behindFixes openclaw#66248.
Related openclaw#66219.
Supersedes openclaw#66295.
Why this carry exists
#66295had the right core direction: move OpenClaw-managed systemd env into a drop-in so upgrades stop clobbering userEnvironmentFile=andEnvironment=directives.The branch still needed maintainer follow-up in three spots:
ExecStart=were no longer repairedWorkingDirectory=values could survive migration and fail startup atCHDIRThis carry fixes those and keeps the user-preserving drop-in design intact.
Verification
pnpm test:serial src/daemon/systemd-unit.test.ts src/daemon/systemd.test.tspnpm buildChangelog
Added under
## Unreleasedwith:Thanks @solomonneas.Carry follow-up: @vincentkoc.