Fix/disable refresh during active turn#2487
Open
BingqingLyu wants to merge 3 commits into
Open
Conversation
…ng gateway Non-recoverable Slack auth errors (account_inactive, invalid_auth, etc.) were throwing out of monitorSlackProvider, propagating as unhandled promise rejections and killing the entire gateway process — taking down all other channels (Telegram, Discord, etc.) with it. Replace the three throw sites with return so the Slack provider stops cleanly while the rest of the gateway keeps running. Fixes the crash-loop reported in openclaw#62268.
The refresh button was only guarded by chatLoading and connected state, allowing clicks during active agent turns. This could stall the run, reset chat state, and wedge the gateway. Add chatSending, chatRunId, and chatStream guards to match the existing busy-state pattern used by the model and thinking selects. Fixes openclaw#65522
25 tasks
Owner
Author
|
| Function | File | Also modified by |
|---|---|---|
renderChatControls |
ui/src/ui/app-render.helpers.ts |
#2363 |
Recommendation: Coordinate with #2363 before merging.
Auto-detected by codegraph — a code graph analysis tool built on neug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chatLoadingor disconnected, remaining clickable during active agent turns.chatSending,chatRunId, andchatStreamguards to the refresh button'sdisabledcondition.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Root Cause (if applicable)
disabledbinding was missing the busy-state guards (chatSending,chatRunId,chatStream) that are already used by the model select and thinking select controls in the same file.busyvariable combining these four flags. The refresh button only had two of them.Regression Test Plan (if applicable)
ui/src/ui/app-render.helpers.tschatSending,chatRunId, andchatStream?disabled), so it's evaluated on every render cycle.User-visible / Behavior Changes
Refresh button is now grayed out and non-clickable while the agent is sending, running, or streaming a response.
Diagram (if applicable)
Security Impact (required)
Repro + Verification
Environment
Steps
Expected
Refresh button should be disabled (grayed out) during the entire agent turn lifecycle.
Actual (before fix)
Refresh button remained clickable. Clicking it mid-turn reset the chat and stalled the run.
Evidence
Before (refresh button clickable during active turn)
After (refresh button disabled during active turn)
Human Verification (required)
Review Conversations
Compatibility / Migration
Risks and Mitigations
chatRunIdorchatStreamare set but the turn is actually stale, leaving the button permanently disabled.resetChatStateForSessionSwitch) clears all three flags.