fix(agents): suppress memory flush UI leakage (#58956)#1786
Open
BingqingLyu wants to merge 1 commit into
Open
Conversation
Prevent pre-compaction memory flush from leaking internal prompts into the chat UI and blocking user's active turn. Root cause: Memory flush increased autoCompactionCount, which triggered system event enqueue and verbose notifications in subsequent turns. Fix: Track performedMemoryFlush flag and suppress UI-visible side effects: - Skip enqueueSystemEvent() for memory flush runs - Skip verbose 'Auto-compaction complete' notification for memory flush runs Tests: Add 14 unit tests covering suppression logic and edge cases. Fixes openclaw#58956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix pre-compaction memory flush leaking internal prompts into chat UI and blocking user's active turn.
Root Cause
Memory flush execution increased
autoCompactionCount, which triggered:drainFormattedSystemEventsin subsequent turnsFix
Track
performedMemoryFlushflag and suppress UI-visible side effects:enqueueSystemEvent()for memory flush runsChanges
MemoryFlushResulttype, return flagTesting
Related
Fixes openclaw#58956