config: Support setting userTimezone per agent#128
Open
BingqingLyu wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agents.defaults.userTimezone, so multi-agent setups could not give different agents correct local time context.agents.list[].userTimezone, introduced shared agent-aware timezone resolution, threadedagentIdthrough the relevant call sites, validated configured IANA timezones in schema, and added tests/docs for the new behavior.timeFormatper agent, host timezone fallback behavior, or explicit non-usertimezone settings such as fixed IANA/UTC/local envelope config.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
agents.list[].userTimezone.userTimezonenow overridesagents.defaults.userTimezone.session_statustime lineactiveHours.timezone: "user""user"envelope timestamps"user"system-event timestampsagents.defaults.userTimezonethen host timezone fallback.userTimezone.Security Impact (required)
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoYes, explain risk + mitigation:Repro + Verification
Environment
Steps
agents.defaults.userTimezoneand a differentagents.list[].userTimezonefor a non-default agent."user"timezone.Expected
userTimezoneoverride everywhere"user"timezone semantics are intended.Actual
Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
pnpm build && pnpm check && pnpm testagents.defaults.userTimezone"user"timezone paths receive the activeagentIdCompatibility / Migration
Yes/No) YesYes/No) YesYes/No) Noagents.list[].userTimezonewhere agent-specific timezone behavior is desired.Failure Recovery (if this breaks)
userTimezoneentries and rely onagents.defaults.userTimezoneor revert this PR.agents.list[]"user"timezone behavior not varying by agentRisks and Mitigations
"user"timezone semantics could miss passingagentIdand silently fall back to the default timezone.AI Assistance
This PR was AI-assisted using GPT-5.4 and Gemini 3.1 Pro.