Conversation
- Update composer.json constraints for laravel/framework, illuminate/contracts, laravel/mcp, orchestra/testbench, and openai-php/laravel - Add Laravel 13 + testbench 11 to CI test matrix - Fix HasActionLogs trait to avoid calling Model::observe() during boot, which triggers recursive model instantiation in Laravel 13
PR Summary
The key benefit of all these changes is increasing the codebase's cleanliess and clarity, making the project much more readable, maintainable, and smooth functioning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
laravel/framework,illuminate/contracts,laravel/mcp,orchestra/testbench, andopenai-php/laravelto support Laravel 13testbench: 11.*) to the GitHub Actions test matrixstatic::observe()with direct event listener registration in theHasActionLogstrait to avoid a recursive model boot issue introduced in Laravel 13Breaking change detail
Laravel 13's
Model::observe()now callsnew staticinternally (source), which triggersbootIfNotBooted()on the same model class that is already mid-boot. This causes aLogicException:The fix registers
created,updating, anddeletedlisteners directly instead of going throughobserve(), avoiding the recursive instantiation.Version matrix
Test plan