Fix path generation for generate:repository command - Fix #712#713
Merged
binaryk merged 1 commit intoBinarCode:10.xfrom Feb 12, 2026
Merged
Fix path generation for generate:repository command - Fix #712#713binaryk merged 1 commit intoBinarCode:10.xfrom
binaryk merged 1 commit intoBinarCode:10.xfrom
Conversation
Basically, I reversed the `str_replace` statements which was wrong. Imagine this namespace: `App\Restify\User`.
With the old code:
```php
str_replace('App\\', 'app/', str_replace('\\', '/', $namespace)).'/'.$className.'.php';
```
it would first execute the `str_replace('\\', '/', $namespace))` which results in this string: `App/Restify/User`, meaning the next code execution is useless:
```php
str_replace('App\\', 'app/', 'App/Restify/User')
```
|
@RomainMazB is attempting to deploy a commit to the BinarCode Team on Vercel. A member of the Team first needs to authorize it. |
PR Summary
|
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, I reversed the
str_replacestatements which was wrong. Imagine this namespace:App\Restify\User.With the old code:
it would first execute the
str_replace('\\', '/', $namespace))which results in this string:App/Restify/User, meaning the next code execution is useless: