Repository navigation
Commit 0543fa6
committed
Exit cleanly when the WebDriver server cannot create a session
`WebDriverService.startTest` only caught `SocketException` around
`createDriver`. When the WebDriver server (chromedriver, safaridriver,
geckodriver) was reachable but failed to launch or connect to the
browser, `package:webdriver` threw a `WebDriverException` such as
`SessionNotCreatedException (500): session not created:
DevToolsActivePort file doesn't exist`, which escaped `flutter drive`
as an unhandled tool crash.
Catch `WebDriverException` as well and turn it into a `ToolExit` that
includes the server's error message and points at the usual causes
(browser not installed, driver/browser version mismatch, session
timeout). Add a regression test that runs a fake WebDriver server which
rejects the session request.
Fixes flutter#1935171 parent 9cba739 commit 0543fa6
2 files changed
Lines changed: 58 additions & 0 deletions
File tree
- packages/flutter_tools
- lib/src/drive
- test/general.shard/drive
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
204 | 219 | | |
205 | 220 | | |
206 | 221 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| 23 | + | |
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
| |||
420 | 422 | | |
421 | 423 | | |
422 | 424 | | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
423 | 466 | | |
424 | 467 | | |
425 | 468 | | |
| |||
0 commit comments