fix(responses): forward url_citation annotations on streaming bridge by gokay-ai · Pull Request #43818 · BerriAI/litellm

gokay-ai · 2026-09-30T06:26:03Z

Fixes

What

OpenAiResponsesToChatCompletionStreamIterator had no branch for response.output_text.annotation.added, so Chat Completions bridged to Responses (openai/responses/...) dropped url_citation annotations when stream=True even though stream=False already returned them.

This maps that event onto delta.annotations the same way native Chat Completions streams do.

Test

Unit test for the annotation.added → delta.annotations path
Offline repro from the issue (httpx transport mock) now returns the citation on both paths

Thanks!

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

response.output_text.annotation.added was unhandled in the Chat Completions bridge, so stream=True dropped citations that stream=False already returned. Fixes BerriAI#43817 Signed-off-by: GokayAI <[email protected]>

greptile-apps · 2026-09-30T06:29:04Z

Confidence Score: 4/5

[Medium risk] Adds annotation forwarding to streaming response transformation.

This PR is not ready to merge until streamed citations use the Chat Completions shape and the explicit comment requirement is met

Findings

Flat citations break clients ▶
Redundant comments violate guidance ▶

Summary

The PR forwards Responses streaming annotation events to Chat Completions deltas and narrows proxy streaming and during-call guardrail capability checks

The annotation bridge preserves the Responses shape rather than producing the nested Chat Completions citation shape
Added explanatory comments conflict with the repository’s comment guidance

_{Reviews (1) · Last reviewed commit: 0351089}

greptile-apps · 2026-09-30T06:29:07Z

+            raw_annotation = parsed_chunk.get("annotation")
+            annotations = LiteLLMResponsesTransformationHandler._convert_annotations_to_chat_format(
+                [raw_annotation] if raw_annotation is not None else None
+            )


Flat citations break clients Responses annotations have flat url and title fields, but this code forwards them unchanged. Chat Completions clients expecting a nested url_citation object cannot read the citation

greptile-apps · 2026-09-30T06:29:07Z

+    """True unless the guardrail is request-only (``pre_call`` / ``pre_mcp_call``).
+
+    Streaming fast-path gates must not treat a purely pre-call guardrail as a
+    reason to pay the per-chunk ``async_post_call_streaming_hook`` path.
+    """


Redundant comments violate guidance These docstrings restate simple predicates. Similar comments appear in the annotation branch and tests. Repository guidance permits comments only for necessary complex logic, tool inputs, or TODOs; this requirement must be met before merging

Context Used: AGENTS.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

CLAassistant · 2026-09-30T06:33:19Z

All committers have signed the CLA.

codspeed · 2026-09-30T06:36:32Z

Merging this PR will not alter performance

✅ 31 untouched benchmarks

_{Comparing gokay-ai:fix/responses-bridge-stream-annotations-43817 (61e6af9) with main (6bc17f9)}

codecov · 2026-09-30T06:41:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Type-discipline gate failed: the new list wrappers for annotation.added exceeded the LIT002 ceiling. Match existing stream-branch annotations. Signed-off-by: GokayAI <[email protected]>

gokay-ai · 2026-09-30T10:23:37Z

I have read the CLA Document and I hereby sign the CLA

Keep mutable-ok on the list-literal line and satisfy ruff format. Signed-off-by: GokayAI <[email protected]>

Stream iterator calls the shared private converter; basedpyright budget failed once LIT002 cleared. Match other cross-class helper ignores. Signed-off-by: GokayAI <[email protected]>

gokay-ai requested review from a team and a balanced review from Copilot September 30, 2026 06:26

Copilot AI reviewed Sep 30, 2026

fix(responses): forward url_citation annotations on streaming bridge

ba37068

response.output_text.annotation.added was unhandled in the Chat Completions bridge, so stream=True dropped citations that stream=False already returned. Fixes BerriAI#43817 Signed-off-by: GokayAI <[email protected]>

gokay-ai force-pushed the fix/responses-bridge-stream-annotations-43817 branch from 0351089 to ba37068 Compare September 30, 2026 06:26

greptile-apps Bot reviewed Sep 30, 2026

View reviewed changes

fix(responses): mark stream annotation lists mutable-ok for LIT002

8eb27a9

Type-discipline gate failed: the new list wrappers for annotation.added exceeded the LIT002 ceiling. Match existing stream-branch annotations. Signed-off-by: GokayAI <[email protected]>

gokay-ai added 2 commits September 30, 2026 13:27

fix(responses): ruff-format annotation.added LIT002 suppressions

73c93bd

Keep mutable-ok on the list-literal line and satisfy ruff format. Signed-off-by: GokayAI <[email protected]>

fix(responses): silence reportPrivateUsage on stream annotation convert

61e6af9

Stream iterator calls the shared private converter; basedpyright budget failed once LIT002 cleared. Match other cross-class helper ignores. Signed-off-by: GokayAI <[email protected]>

Navigation Menu

Repository navigation

fix(responses): forward url_citation annotations on streaming bridge - #43818

fix(responses): forward url_citation annotations on streaming bridge#43818
gokay-ai wants to merge 4 commits into
BerriAI:mainfrom
gokay-ai:fix/responses-bridge-stream-annotations-43817

gokay-ai commented Sep 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

greptile-apps Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Sep 30, 2026

Uh oh!

greptile-apps Bot Sep 30, 2026

Uh oh!

CLAassistant commented Sep 30, 2026 •

edited

Loading

Uh oh!

codspeed Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Sep 30, 2026

Uh oh!

gokay-ai commented Sep 30, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

gokay-ai commented Sep 30, 2026

Fixes

What

Test

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Uh oh!

greptile-apps Bot Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

CLAassistant commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

codecov Bot commented Sep 30, 2026

Codecov Report

Uh oh!

gokay-ai commented Sep 30, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

greptile-apps Bot commented Sep 30, 2026 •

edited

Loading

CLAassistant commented Sep 30, 2026 •

edited

Loading

codspeed Bot commented Sep 30, 2026 •

edited

Loading