feat: add lint-gate target and truncation-proof summary to the strict ruff gate by mateo-berri · Pull Request #30877 · BerriAI/litellm

mateo-berri · 2026-06-20T17:26:37Z

Relevant issues

None; this is developer-experience cleanup for the strict ruff gate that came out of fighting it on a recent PR.

Linear ticket

Pre-Submission checklist

I have added meaningful tests
My PR passes all unit tests on make test-unit
My PR's scope is as isolated as possible; it only solves 1 specific problem
I have requested a Greptile review by commenting @greptileai and received a Confidence Score of at least 4/5 before requesting a maintainer review

CI (LiteLLM team)

Branch creation CI run
Link:
CI run for the last commit
Link:
Merge / cherry-pick CI run
Links:

Screenshots / Proof of Fix

Two pain points with the strict ruff gate and how to see the fix locally.

First, the truncation-proof summary. CI only surfaces the tail of the job log, and the gate printed each breached rule's header before its (potentially long) list of offending files, so on a real failure the rule name and counts scrolled off the top of the captured tail and you could not tell which rule blew the budget. The gate now also prints a single BREACHED RULES: ... line as the very last line, which survives tail truncation. Covered by test_report_emits_breached_rules_as_final_line.

Second, a local entry point that predicts CI. make lint-gate fetches origin/litellm_internal_staging fresh and then runs the gate the same way the lint check does in test-linting.yml (the CI job checks out the PR head sha and counts against the merge-base with the base branch), so a clean local run predicts the CI verdict before you push.

# matches what the lint CI check will conclude, before you push
make lint-gate

Default behavior and the existing make lint-ruff-budget target are unchanged.

Type

🚄 Infrastructure

Changes

scripts/ruff_strict_gate.py always emits a final one-line BREACHED RULES summary so the verdict survives log truncation, and the shared violation-collection logic is factored into collect_violations(root, config) with worktree handling consolidated behind a _temp_worktree context manager that cleans up its temp dir even when git worktree add fails. make lint-gate is a new local entry point that fetches staging fresh and runs the gate exactly as CI does. Tests extend tests/test_litellm/test_ruff_strict_gate.py with a regression for the trailing summary line.

Note

Low Risk
Changes are limited to Makefile targets, the ruff strict gate script, and unit tests—no runtime or proxy behavior.

Overview
Improves strict ruff budget gate developer experience: failures now end with a single BREACHED RULES: line (rule, total/cap, added) so CI log tails still show which rules failed.

Adds make lint-gate, which fetches origin/litellm_internal_staging and runs ruff_strict_gate.py --base the same way contributors expect before push; make lint-ruff-budget is unchanged.

scripts/ruff_strict_gate.py is refactored: shared collect_violations, gather, and a _temp_worktree context manager for base-branch counts; docs note merge-base behavior aligns with CI. A unit test locks in the trailing summary line.

^{Reviewed by Cursor Bugbot for commit 497447a. Bugbot is set up for automated code reviews on this repo. Configure here.}

…gate

codecov · 2026-06-20T17:29:49Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

greptile-apps · 2026-06-20T17:37:27Z

Greptile Summary

This PR improves the developer experience around the strict ruff gate by adding a local make lint-gate target that replicates the CI check exactly and by making failure output survive log tail truncation in CI.

scripts/ruff_strict_gate.py: collect_violations is now parameterized for both head and worktree use; _temp_worktree consolidates worktree lifecycle management and switches the finally cleanup to bare subprocess.run so worktree-removal failures can no longer mask the original exception; a new trailing BREACHED RULES: … line is always the last line of failure output so the verdict is visible even when CI surfaces only the tail of a long log.
Makefile: adds lint-gate which fetches origin/litellm_internal_staging fresh and passes --base origin/litellm_internal_staging, mirroring the CI invocation exactly.
tests/test_litellm/test_ruff_strict_gate.py: adds test_report_emits_breached_rules_as_final_line as a regression guard for the new trailing-summary behaviour.

Confidence Score: 5/5

Safe to merge — changes are confined to the gate script, Makefile, and its tests, with no impact on production code paths.

All three changed files touch developer tooling only (a lint gate script, its Makefile target, and its unit tests). The refactoring is internally consistent: collect_violations is called in both the head and base worktree paths, _temp_worktree correctly suppresses cleanup failures without masking the original error, and the new trailing summary line is directly covered by a regression test. No application logic, request handling, or authentication code is touched.

No files require special attention.

Important Files Changed

Filename	Overview
scripts/ruff_strict_gate.py	Refactors violation collection into a parameterized `collect_violations(root, config)`, consolidates worktree lifecycle into `_temp_worktree` context manager that uses bare `subprocess.run` in the `finally` to avoid masking original exceptions, factors out `gather()` and `report()`, and adds a trailing `BREACHED RULES` summary line so the verdict survives log tail truncation in CI.
Makefile	Adds `lint-gate` to the `.PHONY` list, adds its help text, and adds the target itself — fetches `origin/litellm_internal_staging` then runs the gate with `--base origin/litellm_internal_staging` to match the CI invocation exactly.
tests/test_litellm/test_ruff_strict_gate.py	Adds `test_report_emits_breached_rules_as_final_line` which captures stdout and asserts the last line is the compact `BREACHED RULES` summary, directly covering the new trailing-summary behaviour.

_{Reviews (4): Last reviewed commit: "fix: align lint-gate with CI by dropping..." | Re-trigger Greptile}

mateo-berri · 2026-06-20T17:40:50Z

@greptileai

mateo-berri · 2026-06-20T17:45:42Z

@greptileai

mateo-berri · 2026-06-20T17:48:34Z

bugbot run

Generated by Claude Code

cursor

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Lint gate mismatches CI
- Dropped the --ci-parity flag from the lint-gate Makefile target (and removed the now-unused gather_ci_parity branch plus the misleading docstring claim about CI), so make lint-gate now invokes ruff_strict_gate.py the same way test-linting.yml does.

_{You can send follow-ups to the cloud agent here.}

The lint-gate Makefile target invoked ruff_strict_gate.py with --ci-parity, which counted violations on a throwaway merge of base into HEAD against base counts at the base tip. CI in test-linting.yml runs the same script without --ci-parity on a PR-head checkout, taking the gather_fast path that counts on the live tree against base counts at the merge-base. A local pass could therefore disagree with CI. Drop --ci-parity from the Makefile and remove the now-unused gather_ci_parity branch and flag so there is one code path that both local and CI exercise. The docstring claim that CI runs against the synthetic merge ref was also wrong; the workflow checks out github.event.pull_request.head.sha.

CLAassistant · 2026-06-20T17:52:36Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mateo-berri
❌ cursoragent
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

yucheng-berri

nit: ci-parity mode was dropped and the body no longer matches the code.

mateo-berri · 2026-06-20T18:29:43Z

@greptileai

Generated by Claude Code

mateo-berri · 2026-06-20T18:33:13Z

bugbot run

Generated by Claude Code

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 497447a. Configure here.}

Jason-123-cyber · 2026-06-24T11:21:24Z

Ok

Jason-123-cyber · 2026-06-24T11:22:32Z

Greptile Summary

This PR improves the developer experience around the strict ruff gate by adding a local make lint-gate target that replicates the CI check exactly and by making failure output survive log tail truncation in CI.

scripts/ruff_strict_gate.py: collect_violations is now parameterized for both head and worktree use; _temp_worktree consolidates worktree lifecycle management and switches the finally cleanup to bare subprocess.run so worktree-removal failures can no longer mask the original exception; a new trailing BREACHED RULES: … line is always the last line of failure output so the verdict is visible even when CI surfaces only the tail of a long log.

Makefile: adds lint-gate which fetches origin/litellm_internal_staging fresh and passes --base origin/litellm_internal_staging, mirroring the CI invocation exactly.

tests/test_litellm/test_ruff_strict_gate.py: adds test_report_emits_breached_rules_as_final_line as a regression guard for the new trailing-summary behaviour.

Confidence Score: 5/5

Safe to merge — changes are confined to the gate script, Makefile, and its tests, with no impact on production code paths.

All three changed files touch developer tooling only (a lint gate script, its Makefile target, and its unit tests). The refactoring is internally consistent: collect_violations is called in both the head and base worktree paths, _temp_worktree correctly suppresses cleanup failures without masking the original error, and the new trailing summary line is directly covered by a regression test. No application logic, request handling, or authentication code is touched.

No files require special attention.

Important Files Changed

Filename Overview

scripts/ruff_strict_gate.py Refactors violation collection into a parameterized collect_violations(root, config), consolidates worktree lifecycle into _temp_worktree context manager that uses bare subprocess.run in the finally to avoid masking original exceptions, factors out gather() and report(), and adds a trailing BREACHED RULES summary line so the verdict survives log tail truncation in CI.

Makefile Adds lint-gate to the .PHONY list, adds its help text, and adds the target itself — fetches origin/litellm_internal_staging then runs the gate with --base origin/litellm_internal_staging to match the CI invocation exactly.

tests/test_litellm/test_ruff_strict_gate.py Adds test_report_emits_breached_rules_as_final_line which captures stdout and asserts the last line is the compact BREACHED RULES summary, directly covering the new trailing-summary behaviour.

_{Reviews (4): Last reviewed commit: "fix: align lint-gate with CI by dropping..." | Re-trigger Greptile}

K

… ruff gate (BerriAI#30877) * feat: add CI-parity mode and truncation-proof summary to strict ruff gate * refactor: tolerant worktree cleanup and concrete GateInputs types * fix: clean up temp dir when git worktree add fails * fix: align lint-gate with CI by dropping unused --ci-parity path The lint-gate Makefile target invoked ruff_strict_gate.py with --ci-parity, which counted violations on a throwaway merge of base into HEAD against base counts at the base tip. CI in test-linting.yml runs the same script without --ci-parity on a PR-head checkout, taking the gather_fast path that counts on the live tree against base counts at the merge-base. A local pass could therefore disagree with CI. Drop --ci-parity from the Makefile and remove the now-unused gather_ci_parity branch and flag so there is one code path that both local and CI exercise. The docstring claim that CI runs against the synthetic merge ref was also wrong; the workflow checks out github.event.pull_request.head.sha. --------- Co-authored-by: Cursor Agent <[email protected]>

Jason-123-cyber · 2026-06-25T07:59:09Z

K

feat: add CI-parity mode and truncation-proof summary to strict ruff …

f491dd5

…gate

mateo-berri marked this pull request as ready for review June 20, 2026 17:33

greptile-apps Bot reviewed Jun 20, 2026

View reviewed changes

Comment thread scripts/ruff_strict_gate.py Outdated

Comment thread scripts/ruff_strict_gate.py Outdated

refactor: tolerant worktree cleanup and concrete GateInputs types

61d167e

fix: clean up temp dir when git worktree add fails

bdce6c7

cursor Bot reviewed Jun 20, 2026

View reviewed changes

Comment thread Makefile Outdated

mateo-berri requested a review from yucheng-berri June 20, 2026 17:58

yucheng-berri approved these changes Jun 20, 2026

View reviewed changes

mateo-berri changed the title ~~feat: add CI-parity mode and truncation-proof summary to strict ruff gate~~ feat: add lint-gate target and truncation-proof summary to the strict ruff gate Jun 20, 2026

cursor Bot reviewed Jun 20, 2026

View reviewed changes

mateo-berri merged commit a7b0b0b into litellm_internal_staging Jun 20, 2026
145 of 162 checks passed

mateo-berri deleted the litellm_ruff_gate_dx branch June 20, 2026 18:46

ishaan-berri mentioned this pull request Jun 25, 2026

LiteLLM Stability Sprint Roadmap #30484

Open

13 tasks

Uh oh!

Uh oh!

Conversation

mateo-berri commented Jun 20, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Relevant issues

Linear ticket

Pre-Submission checklist

CI (LiteLLM team)

Screenshots / Proof of Fix

Type

Changes

Uh oh!

codecov Bot commented Jun 20, 2026

Codecov Report

Uh oh!

greptile-apps Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

mateo-berri commented Jun 20, 2026

Uh oh!

mateo-berri commented Jun 20, 2026

Uh oh!

mateo-berri commented Jun 20, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CLAassistant commented Jun 20, 2026

Uh oh!

yucheng-berri left a comment

Choose a reason for hiding this comment

Uh oh!

mateo-berri commented Jun 20, 2026

Uh oh!

mateo-berri commented Jun 20, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jason-123-cyber commented Jun 24, 2026

Uh oh!

Jason-123-cyber commented Jun 24, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Jason-123-cyber commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mateo-berri commented Jun 20, 2026 •

edited by cursor Bot

Loading

greptile-apps Bot commented Jun 20, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading