chore(test): remove dead old Playwright e2e suite#28632
Merged
yuneng-berri merged 1 commit intoMay 22, 2026
Conversation
The Playwright suite under tests/proxy_admin_ui_tests/e2e_ui_tests/ is no longer wired into CI (only test_*.py is globbed) and every active spec is duplicated by ui/litellm-dashboard/e2e_tests/tests/ (login, auth redirect, search users, internal user list). team_admin.spec.ts was entirely commented out. Removing the directory plus its only-used-here playwright config, package.json/lock, and utils/login.ts keeps the canonical suite under ui/litellm-dashboard/e2e_tests/ as the single source of truth.
Contributor
Greptile SummaryRemoves the unused Playwright e2e suite under
Confidence Score: 5/5Pure deletion of dead, unreferenced test files — no production code or active CI paths are touched. Every deleted file was confirmed unreferenced in CI and the broader codebase. The modern ui/litellm-dashboard/e2e_tests/ suite covers the same scenarios, and the Python tests in tests/proxy_admin_ui_tests/ are untouched. Nothing here can regress runtime behavior. No files require special attention.
|
| Filename | Overview |
|---|---|
| tests/proxy_admin_ui_tests/e2e_ui_tests/login_to_ui.spec.ts | Deleted — login spec superseded by ui/litellm-dashboard/e2e_tests/tests/login/login.spec.ts |
| tests/proxy_admin_ui_tests/e2e_ui_tests/require_auth_for_dashboard.spec.ts | Deleted — auth redirect spec superseded by ui/litellm-dashboard/e2e_tests/tests/auth/unauthenticatedRedirect.spec.ts |
| tests/proxy_admin_ui_tests/e2e_ui_tests/search_users.spec.ts | Deleted — search users spec superseded by ui/litellm-dashboard/e2e_tests/tests/users/searchUsers.spec.ts |
| tests/proxy_admin_ui_tests/e2e_ui_tests/team_admin.spec.ts | Deleted — was entirely commented-out dead code since landing; no coverage lost |
| tests/proxy_admin_ui_tests/e2e_ui_tests/view_internal_user.spec.ts | Deleted — superseded by ui/litellm-dashboard/e2e_tests/tests/users/viewInternalUsers.spec.ts |
| tests/proxy_admin_ui_tests/e2e_ui_tests/view_user_info.spec.ts | Deleted — ad-hoc admin user-info click test with no direct equivalent; minor coverage gap noted in PR description |
| tests/proxy_admin_ui_tests/package.json | Deleted — only served the removed e2e suite; no other consumers |
| tests/proxy_admin_ui_tests/package-lock.json | Deleted — lockfile for the removed package.json |
| tests/proxy_admin_ui_tests/playwright.config.ts | Deleted — old Playwright config that was only used by the removed specs |
| tests/proxy_admin_ui_tests/utils/login.ts | Deleted — login utility only referenced by the removed specs |
| tests/proxy_admin_ui_tests/e2e_ui_tests/redirect-fail-screenshot.png | Deleted — artifact screenshot committed alongside the now-removed spec |
Reviews (1): Last reviewed commit: "chore(test): remove dead old Playwright ..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
yuneng-berri
approved these changes
May 22, 2026
yuneng-berri
merged commit 6439899
into
litellm_internal_staging
116 of 117 checks passed
fzowl
pushed a commit
to fzowl/litellm
that referenced
this pull request
Jun 24, 2026
The Playwright suite under tests/proxy_admin_ui_tests/e2e_ui_tests/ is no longer wired into CI (only test_*.py is globbed) and every active spec is duplicated by ui/litellm-dashboard/e2e_tests/tests/ (login, auth redirect, search users, internal user list). team_admin.spec.ts was entirely commented out. Removing the directory plus its only-used-here playwright config, package.json/lock, and utils/login.ts keeps the canonical suite under ui/litellm-dashboard/e2e_tests/ as the single source of truth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes the unused Playwright suite under
tests/proxy_admin_ui_tests/e2e_ui_tests/along with its only-used-hereplaywright.config.ts,package.json/ lockfile, andutils/login.ts. Nothing in CI runs these specs (the CircleCIe2e_ui_testingjob globstests/proxy_admin_ui_tests/**/test_*.py— Python only — and runs the modern Playwright suite underui/litellm-dashboard/e2e_tests/). The Python unit tests directly undertests/proxy_admin_ui_tests/(test_key_management.py,test_role_based_access.py, etc.) are untouched.Every active spec being removed is already duplicated by the modern suite at
ui/litellm-dashboard/e2e_tests/tests/:login_to_ui.spec.ts↔login/login.spec.tsrequire_auth_for_dashboard.spec.ts↔auth/unauthenticatedRedirect.spec.tssearch_users.spec.ts↔users/searchUsers.spec.tsview_internal_user.spec.ts↔users/viewInternalUsers.spec.tsview_user_info.spec.ts— ad-hoc admin user-info click; not in the QA migration listteam_admin.spec.ts— entirely commented out, dead since landingThis keeps
ui/litellm-dashboard/e2e_tests/as the single source of truth for UI e2e and removes a confusing second config that was easy to mistake for active coverage.Test plan
grep -rn "proxy_admin_ui_tests/e2e_ui_tests\|e2e_ui_tests"returns no hits in.circleci/, scripts, docs, or remaining test filestests/proxy_admin_ui_tests/**/test_*.py(Python only) — unaffectedui/litellm-dashboard/e2e_tests/run_e2e.shstill runs againstui/litellm-dashboard/e2e_tests/playwright.config.tsRefs LIT-3093 (E2E test coverage tracking).