Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Greptile SummaryThis PR adds a Vanta compliance blog post (SOC 2 Type 2 / ISO 27001 recertification announcement) along with its image asset, renames Azure environment variables in the setup wizard from
Confidence Score: 3/5Not safe to merge as-is: permanently deletes test coverage for a core provider path and carries forward the unresolved Azure env-var naming issue. Two unresolved concerns remain: (1) the
|
| Filename | Overview |
|---|---|
| tests/llm_translation/test_fireworks_ai_translation.py | Removes the entire TestFireworksAIChatCompletion class (previously skipped for an active outage) instead of restoring or relocating it, permanently eliminating chat-completion test coverage for Fireworks AI. |
| litellm/setup_wizard.py | Renames Azure env vars from AZURE_API_KEY/_LITELLM_AZURE_API_BASE_ to AZURE_AI_API_KEY/_LITELLM_AZURE_AI_API_BASE_; previously flagged for potential mismatch with the Azure OpenAI naming convention used elsewhere in the codebase. |
| docs/my-website/blog/vanta_compliance_recertification/index.md | New blog post announcing LiteLLM + Vanta SOC 2 Type 2 and ISO 27001 recertification; documentation-only addition, no issues found. |
| docs/my-website/static/img/blog/vanta_soc2_recertification.png | New static image asset for the Vanta blog post; no issues. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User runs setup wizard] --> B{Provider selection}
B -->|Azure OpenAI| C[Prompt for API key\nenv: AZURE_AI_API_KEY]
B -->|Other providers| D[Prompt for env-specific key]
C --> E[Prompt for API base URL]
E --> F[Store in _LITELLM_AZURE_AI_API_BASE_AZURE]
F --> G[Generate proxy config YAML\napi_base from stored env var]
G --> H[Write config.yaml]
D --> H
Reviews (2): Last reviewed commit: "docs: cleanup image" | Re-trigger Greptile
| "name": "Azure OpenAI", | ||
| "description": "GPT-4o via Azure", | ||
| "env_key": "AZURE_API_KEY", | ||
| "env_key": "AZURE_AI_API_KEY", |
There was a problem hiding this comment.
Env var mismatch: Azure OpenAI vs Azure AI Foundry
The provider here is labelled "Azure OpenAI" (GPT-4o via Azure), whose conventional env var throughout the litellm codebase is the one used in litellm/llms/azure/common_utils.py, litellm/main.py, and litellm/batches/main.py — i.e. the AZURE_*_KEY (without the AI segment).
The AZURE_AI_*_KEY variant (with AI) is specifically for the Azure AI Foundry/Services route and is only used within litellm/llms/azure_ai/.
Changing the wizard's env_key to the AZURE_AI_* name means:
- The generated YAML will reference the
AI-suffixed variable name. - Users who have the standard Azure OpenAI key set under the conventional name will have a broken config.
- It contradicts the naming convention used everywhere else in the repo for Azure OpenAI.
If this is intentionally targeting Azure AI Foundry, please update the provider description and model list accordingly; otherwise revert to the Azure OpenAI variable name.
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/test_litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unit@greptileaiand received a Confidence Score of at least 4/5 before requesting a maintainer reviewDelays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
CI (LiteLLM team)
Branch creation CI run
Link:
CI run for the last commit
Link:
Merge / cherry-pick CI run
Links:
Type
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes