Skip to content

[Docs] Add missing team_member_budget_duration param to new_team docstring#24243

Merged
yuneng-jiang merged 2 commits intomainfrom
litellm_/gifted-spence
Mar 20, 2026
Merged

[Docs] Add missing team_member_budget_duration param to new_team docstring#24243
yuneng-jiang merged 2 commits intomainfrom
litellm_/gifted-spence

Conversation

@yuneng-jiang
Copy link
Copy Markdown
Contributor

Summary

Failure Path (Before Fix)

The test_api_docs.py CI check validates that all Pydantic model fields on management endpoints have corresponding docstring entries. The new_team endpoint was missing documentation for the team_member_budget_duration parameter, causing CI to fail.

Fix

Added the missing team_member_budget_duration parameter documentation to the new_team docstring in team_endpoints.py.

Testing

  • Ran test_api_docs.py locally — passes with no errors.

Type

📖 Documentation

Fixes CI failure in test_api_docs.py which validates that all Pydantic
model fields are documented in endpoint docstrings.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
litellm Ready Ready Preview, Comment Mar 20, 2026 7:49pm

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 20, 2026

Greptile Summary

This PR adds a single missing docstring entry — team_member_budget_duration — to the new_team endpoint in team_endpoints.py, resolving a CI failure in test_api_docs.py that validates all Pydantic model fields have corresponding docstring entries.

  • The new line is correctly placed between team_member_budget and team_member_rpm_limit, consistent with the logical ordering of the surrounding parameters.
  • The format (Optional[str], link to https://docs.litellm.ai/docs/proxy/team_budgets) matches the analogous budget_duration entry on line 714.
  • No logic, behaviour, or tests are changed — this is a pure documentation fix.

Confidence Score: 5/5

  • This PR is safe to merge — it is a one-line documentation-only change with no functional impact.
  • The change adds a single missing docstring entry that directly unblocks a failing CI check. It touches no logic, no tests, no data models, and no runtime paths. The added line is consistent in format and content with the surrounding documentation.
  • No files require special attention.

Important Files Changed

Filename Overview
litellm/proxy/management_endpoints/team_endpoints.py Added missing team_member_budget_duration docstring entry to the new_team endpoint, fixing the test_api_docs.py CI check. Change is minimal, correctly placed, and consistent with surrounding documentation format.

Sequence Diagram

sequenceDiagram
    participant Client
    participant new_team endpoint
    participant Pydantic Model (NewTeamRequest)

    Client->>new_team endpoint: POST /team/new (team_member_budget_duration=...)
    new_team endpoint->>Pydantic Model (NewTeamRequest): Validate request body
    Pydantic Model (NewTeamRequest)-->>new_team endpoint: Validated data (incl. team_member_budget_duration)
    new_team endpoint-->>Client: 200 OK (team created)

    note over new_team endpoint: Docstring now documents<br/>team_member_budget_duration<br/>fixing test_api_docs.py CI
Loading

Last reviewed commit: "Merge branch 'main' ..."

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq bot commented Mar 20, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks


Comparing litellm_/gifted-spence (4d19855) with main (c6ffda9)

Open in CodSpeed

@yuneng-jiang yuneng-jiang merged commit 50f88c8 into main Mar 20, 2026
79 of 99 checks passed
@ishaan-berri ishaan-berri deleted the litellm_/gifted-spence branch March 26, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants