Fixed thinking blocks dropped when thinking field is null (#24026)

xr843 · claude · xr843 · commit 8969a3d1763e · 2026-03-19T09:10:21.000+08:00
The check `content.get("thinking", None) is not None` incorrectly drops thinking blocks when the `thinking` key is explicitly null or absent. Changed to `content.get("type") == "thinking"` to match the fix already applied in the experimental pass-through path (PR #15501). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
diff --git a/litellm/llms/anthropic/chat/transformation.py b/litellm/llms/anthropic/chat/transformation.py
@@ -1522,7 +1522,7 @@ def extract_response_content(
                         tool_results = []
                     tool_results.append(content)
 
-            elif content.get("thinking", None) is not None:
+            elif content.get("type") == "thinking":
                 if thinking_blocks is None:
                     thinking_blocks = []
                 thinking_blocks.append(cast(ChatCompletionThinkingBlock, content))
diff --git a/tests/test_litellm/llms/anthropic/chat/test_anthropic_chat_transformation.py b/tests/test_litellm/llms/anthropic/chat/test_anthropic_chat_transformation.py
@@ -3321,3 +3321,54 @@ def test_map_tool_helper_empty_parameters_get_default():
     assert result is not None
     assert result["input_schema"]["type"] == "object"
     assert result["input_schema"].get("properties") == {}
+
+
+def test_extract_response_content_thinking_block_null_thinking():
+    """
+    Test that thinking blocks are not dropped when the 'thinking' field is null
+    or missing. Regression test for https://github.com/BerriAI/litellm/issues/24026
+    """
+    config = AnthropicConfig()
+
+    # Case 1: thinking key is explicitly null
+    completion_response_null = {
+        "content": [
+            {"type": "thinking", "thinking": None, "signature": "sig123"},
+            {"type": "text", "text": "Hello"},
+        ]
+    }
+    text, _, thinking_blocks, _, _, _, _, _ = config.extract_response_content(
+        completion_response_null
+    )
+    assert thinking_blocks is not None, "thinking blocks should not be None when thinking=null"
+    assert len(thinking_blocks) == 1
+    assert "Hello" in text
+
+    # Case 2: thinking key is absent entirely
+    completion_response_missing = {
+        "content": [
+            {"type": "thinking", "signature": "sig456"},
+            {"type": "text", "text": "World"},
+        ]
+    }
+    text, _, thinking_blocks, _, _, _, _, _ = config.extract_response_content(
+        completion_response_missing
+    )
+    assert thinking_blocks is not None, "thinking blocks should not be None when thinking key is absent"
+    assert len(thinking_blocks) == 1
+    assert "World" in text
+
+    # Case 3: thinking key has actual content (should still work)
+    completion_response_text = {
+        "content": [
+            {"type": "thinking", "thinking": "Let me think...", "signature": "sig789"},
+            {"type": "text", "text": "Done"},
+        ]
+    }
+    text, _, thinking_blocks, _, _, _, _, _ = config.extract_response_content(
+        completion_response_text
+    )
+    assert thinking_blocks is not None
+    assert len(thinking_blocks) == 1
+    assert thinking_blocks[0]["thinking"] == "Let me think..."
+    assert "Done" in text
