Skip to content

Commit 7cf692e

Browse files
Move CLI SSO user defined values build inside try/except for consistent error handling
Co-authored-by: Yassin Kortam <[email protected]>
1 parent cc87bc2 commit 7cf692e

1 file changed

Lines changed: 12 additions & 10 deletions

File tree

litellm/proxy/management_endpoints/ui_sso.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2088,17 +2088,19 @@ async def cli_sso_callback(
20882088
# After None check, cast to non-None type for type checker
20892089
result_non_none: Union[OpenID, dict] = cast(Union[OpenID, dict], result)
20902090

2091-
parsed_openid_result = SSOAuthenticationHandler._get_user_email_and_id_from_result(
2092-
result=result_non_none,
2093-
generic_client_id=os.getenv("GENERIC_CLIENT_ID", None),
2094-
)
2095-
verbose_proxy_logger.debug(f"parsed_openid_result: {parsed_openid_result}")
2096-
user_defined_values = await _build_cli_sso_user_defined_values(
2097-
result=result_non_none,
2098-
parsed_openid_result=parsed_openid_result,
2099-
)
2100-
21012091
try:
2092+
parsed_openid_result = (
2093+
SSOAuthenticationHandler._get_user_email_and_id_from_result(
2094+
result=result_non_none,
2095+
generic_client_id=os.getenv("GENERIC_CLIENT_ID", None),
2096+
)
2097+
)
2098+
verbose_proxy_logger.debug(f"parsed_openid_result: {parsed_openid_result}")
2099+
user_defined_values = await _build_cli_sso_user_defined_values(
2100+
result=result_non_none,
2101+
parsed_openid_result=parsed_openid_result,
2102+
)
2103+
21022104
return await _complete_cli_sso_callback_session(
21032105
request=request,
21042106
key=cast(str, key),

0 commit comments

Comments
 (0)