Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: BerkeleyTrue/warning
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.0.0
Choose a base ref
...
head repository: BerkeleyTrue/warning
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.0.0
Choose a head ref
  • 13 commits
  • 10 files changed
  • 4 contributors

Commits on Jun 21, 2017

  1. chore(README): Add FAQ and link to FB warning

    Add links to FB's warning. Add FAQ about common issues
    BerkeleyTrue authored Jun 21, 2017
    Configuration menu
    Copy the full SHA
    3dad9ee View commit details
    Browse the repository at this point in the history

Commits on May 22, 2018

  1. fix: Update warning to use the latest version from facebook/fbjs

    BREAKING CHANGE: This changes the internal workings. A major release is
    made to ensure minimal effect on downstream users.
    Emeegeemee authored and BerkeleyTrue committed May 22, 2018
    Configuration menu
    Copy the full SHA
    0572ddd View commit details
    Browse the repository at this point in the history
  2. chore(LICENSE): Change from BSD modified to MIT

    Facebook has since release this software under the MIT license. This
    commit does the same
    
    BREAKING CHANGE: Change License to MIT from BSD+patents
    BerkeleyTrue committed May 22, 2018
    Configuration menu
    Copy the full SHA
    5a63a1b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cbe0c4c View commit details
    Browse the repository at this point in the history
  4. Merge pull request #21 from BerkeleyTrue/fix/update-to-match-fbjs

    Update warning to use the latest version from facebook/fbjs
    BerkeleyTrue authored May 22, 2018
    Configuration menu
    Copy the full SHA
    089d8b8 View commit details
    Browse the repository at this point in the history
  5. fix: Remove "browser" version

    closes #18
    
    Since the problem with uglify is fixed there is not reason to keep
    browser version which do not add any benefits. Actually it blocks us
    from distributing `esm` version which is widely used these days and
    supported by the most popular bundlers like webpack, rollup and parcel.
    
    Here's a few links
    facebook/fbjs#86 (comment)
    
    Both uglify and babel minify support evaulation and eliminating
    
    ```js
    (function () {
      function warning() {}
    
      var __DEV__ = 'production' !== 'production'
    
      if (__DEV__) {
        warning = function (msg) {
          console.log(msg)
        }
      }
    
      warning()
    } ());
    ```
    
    https://skalman.github.io/UglifyJS-online/
    
    https://babeljs.io/repl#?babili=true&browsers=&build=&builtIns=false&code_lz=BQMwrgdgxgLglgewgAmASmQbwFDOeaeJZAdwEMAnCOCAc3SwF9tdkA3S5AfS4BEBRAGo9kAXmQByAA4UEAEzCxEECcgCEo8dNkKlSCSzxwQqHgOFcMOPHnJUatMfkh6UwALYBnWldY3kUEieCAA2AKYAdCEI9F4-fsjMeMysdtR06NiMqGhoANxAA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=false&fileSize=false&lineWrap=false&presets=babili%2Cenv&prettier=false&targets=&version=6.26.0&envVersion=1.6.2
    TrySound authored and BerkeleyTrue committed May 22, 2018
    Configuration menu
    Copy the full SHA
    521f5f5 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #22 from BerkeleyTrue/trysound/fix/remove-browser-…

    …version
    
    Remove "browser" version
    BerkeleyTrue authored May 22, 2018
    Configuration menu
    Copy the full SHA
    6101286 View commit details
    Browse the repository at this point in the history
  7. chore(README): Remove section on browserify

    This section is no longer needed as browserify will evaluate boolean
    vars and remove deadcode
    BerkeleyTrue committed May 22, 2018
    Configuration menu
    Copy the full SHA
    52761cf View commit details
    Browse the repository at this point in the history
  8. chore(CHANGELOG): Format using angular convention

    Make use of standard release tools
    BerkeleyTrue committed May 22, 2018
    Configuration menu
    Copy the full SHA
    04896a7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2ece684 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    8344a89 View commit details
    Browse the repository at this point in the history
  11. docs(CHANGELOG): v4.0.0

    BerkeleyTrue committed May 22, 2018
    Configuration menu
    Copy the full SHA
    c3d687a View commit details
    Browse the repository at this point in the history
  12. chore(release): v4.0.0

    BerkeleyTrue committed May 22, 2018
    Configuration menu
    Copy the full SHA
    14967a7 View commit details
    Browse the repository at this point in the history
Loading