Fix netfx & netcore build targets, and add target framework variants #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
Kasuromi
approved these changes
Nov 26, 2023
js6pak
requested changes
Nov 26, 2023
Runtimes/NET/BepInEx.NET.Framework.Launcher/BepInEx.NET.Framework.Launcher.csproj
Outdated
Show resolved
Hide resolved
js6pak
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Marks NetFX builds as x86, restructures their outputs correctly and adds variants for:
Motivation and Context
NetFX and NETCore builds were never widely used and as a result have been broken unnoticed. This adds support for variants which is something I've always wanted to do, and is basically a requirement for any more features to be added in this BepInEx target.
How Has This Been Tested?
Ran build with target
Publish, tested the final .zip files and they work as-is in XNA games I've tested.Screenshots (if appropriate):
Types of changes
Checklist: