Make Logger.Listeners and Logger.Sources thread safe #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManlyMarco
commented
Aug 29, 2023
Member
Author
ManlyMarco
left a comment
ManlyMarco
left a comment
There was a problem hiding this comment.
After testing in a bunch of different games this seems to work perfectly fine so I'll just merge it in preparation for an upcoming BepInEx update.
aldelaro5
added a commit
to aldelaro5/BepInEx
that referenced
this pull request
Sep 15, 2024
Originally pull request BepInEx#656
aldelaro5
added a commit
to aldelaro5/BepInEx
that referenced
this pull request
Sep 16, 2024
Originally pull request BepInEx#656
aldelaro5
added a commit
to aldelaro5/BepInEx
that referenced
this pull request
Sep 17, 2024
Originally pull request BepInEx#656 Co-authored-by: ManlyMarco <[email protected]>
aldelaro5
added a commit
to aldelaro5/BepInEx
that referenced
this pull request
Sep 17, 2024
Originally pull request BepInEx#656 Co-authored-by: ManlyMarco <[email protected]>
js6pak
pushed a commit
that referenced
this pull request
Sep 17, 2024
Originally pull request #656 Co-authored-by: ManlyMarco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding or removing
Logger.ListenersandLogger.Sourcescan cause exceptions if some other thread is currently enumerating these lists, e.g. when callingLogger.Log. This usually causes unexpected crashes in whatever code was trying to log something at an unfortunate time. I noticed it can also lead to a listener not getting some log messages.The changes result in sending log events being slightly faster with no allocations (saves a few ms overall), but Add/Remove operations are slightly slower (still 0 ms overall).
Fixes #655
Types of changes
Checklist: