Skip to content

Conversation

@xKiraiChan
Copy link
Contributor

Description

I added protected to the access modifiers for the ConfigEntryBase constructor

Motivation and Context

This allows for an external assembly to create a type that extends off of ConfigEntryBase
Currently, the only constructor is internal, which prevents an external assembly from creating a class that derives from it

How Has This Been Tested?

I built the project in both debug and release mode.
I replaced the existing BepInEx.Core.dll in my install with a new one
Everything seemed normal

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@ghorsington ghorsington merged commit 9ea3ee8 into BepInEx:master Apr 21, 2022
@ghorsington
Copy link
Contributor

ghorsington commented Apr 21, 2022

Thank you for the PR! Looks good to me, so I merged it in.

@xKiraiChan xKiraiChan deleted the patch-1 branch April 21, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants