Allow experimental for serial implicit coupling scheme.#6
Closed
BenjaminRodenberg wants to merge 52 commits intoprototype_waveform_read_writefrom
Closed
Allow experimental for serial implicit coupling scheme.#6BenjaminRodenberg wants to merge 52 commits intoprototype_waveform_read_writefrom
BenjaminRodenberg wants to merge 52 commits intoprototype_waveform_read_writefrom
Conversation
34 tasks
…ondingly. Related to precice#1196
* Auto generate test suites * Update files * Add reminder to run updateSourceFiles * Add changelog
* Fix format-all-docker modifying file owner * Add changelog
…rallel-implicit-read-direction
Triangle equality no longer involves normal vector.
* Add tests for non-experimental API and subcycling.
* Test reading and writing of data when subcycling.
* Add tests for serial and parallel, explicit and implicit coupling with subcycling.
* Add test for subcycling with compositional coupling scheme.
…implicit-read-direction
* Make configuration files valid by adding participants. * Also provide participant configuration. * Refactor tests w.r.t readability.
…it-read-direction
…parallel-implicit-read-direction
Co-authored-by: Frédéric Simonis <[email protected]>
…precice/precice into refactor-solver-interface-impl-map-data
…parallel-implicit-read-direction
* Added barycentric computation for triangles in 2D + tests * Added assertion * Added assertion * Fixed assertion * fixed assertion * removed test for degenerate triangles in NP mapping (now forbidden)
* Make configuration files valid by adding participants. * Also provide participant configuration. * Refactor tests w.r.t readability. * Use variable dimensions for better readability.
* Fixed offsets calculation in gradient mapping and removed conservative mapping for nearest neighbor gradient * Update src/mapping/NearestNeighborGradientMapping.cpp Co-authored-by: David Schneider <[email protected]> * added changelog * applied styling script * fix typo * updated comment about the offsets calculations * clang-format applied * comment added about scaled consistent mapping * fixed comment about scaled-consistent mapping * Fixed comment about scaled-consistent and fixed formatting * fixed tests * fixed scaled-consistent warning Co-authored-by: David Schneider <[email protected]>
* Move isMappingRequired into DataContext. * Move mapData inside DataContext. * Move mapping into DataContext and make functions private. * Move debug statement inside DataContext. * Improve readability. * Remove some trivial private getters. Co-authored-by: Frédéric Simonis <[email protected]> Co-authored-by: David Schneider <[email protected]>
…implicit-waveform-data-init
12 tasks
Owner
Author
|
I'm closing this PR in favor of precice#1029. It has diverted too much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Allow data initialization for both participants with experimental waveform API and config.
Motivation and additional information
Data initialization of the the first participant is not allowed for a serial implicit coupling scheme. However, we need it, if we want to allow waveform relaxation, because otherwise the second participant can never receive any initial data.
I'm extracting this Work package from precice#1029, because it requires multiple (possibly breaking) changes.
Author's checklist
make changelogif there are user-observable changes since the last release.make formatto ensure everything is formatted correctly.Reviewers' checklist