Allow to initialize write data#2
Closed
BenjaminRodenberg wants to merge 3 commits intodata-context-to-waveform-contextfrom
Closed
Allow to initialize write data#2BenjaminRodenberg wants to merge 3 commits intodata-context-to-waveform-contextfrom
BenjaminRodenberg wants to merge 3 commits intodata-context-to-waveform-contextfrom
Conversation
34 tasks
Owner
Author
|
To reach the goal of this PR, we actually have to communicate and map not |
Owner
Author
|
Already covered in #1. Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Add API function
initializeWriteScalarData(writeData, vertexIDs, dataID)which allows to set value of Waveform at starting time of the simulation. This is an optional API call.Motivation and additional information
Currently we can only use constant interpolation in the first window, since only one data point is available from
writeScalarData. This data is associated with the end of the window. Offering an API callinitializeWriteScalarDatawhich must be called beforeinitializeDataallows us to provide data associated with the beginning of the first window. Together with the data provided viawriteScalarDatathis allows linear interpolation already in the first window.Note that for the second and following windows the data from the previous window will be used to define the linear interpolation. Therefore, the API call
initializeWriteScalarDatashould only change the behavior in the first window.Todos
Author's checklist
docs/changelog/if there are noteworthy changes.tools/formatting/check-formatand everything is formatted correctly.Reviewers' checklist